[GitHub] spark issue #17091: [SPARK-19757][CORE] DriverEndpoint#makeOffers race again...

2017-03-07 Thread jxiang
Github user jxiang commented on the issue: https://github.com/apache/spark/pull/17091 Oh, sorry, I closed it by mistake. I'd like to get it in. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #17091: [SPARK-19757][CORE] DriverEndpoint#makeOffers rac...

2017-03-07 Thread jxiang
GitHub user jxiang reopened a pull request: https://github.com/apache/spark/pull/17091 [SPARK-19757][CORE] DriverEndpoint#makeOffers race against CoarseGrainedSchedulerBackend#killExecutors ## What changes were proposed in this pull request? While some executors are being

[GitHub] spark pull request #17091: [SPARK-19757][CORE] DriverEndpoint#makeOffers rac...

2017-03-07 Thread jxiang
Github user jxiang closed the pull request at: https://github.com/apache/spark/pull/17091 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #17091: [SPARK-19757][CORE] DriverEndpoint#makeOffers rac...

2017-03-07 Thread jxiang
Github user jxiang commented on a diff in the pull request: https://github.com/apache/spark/pull/17091#discussion_r104726794 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1646,7 +1646,7 @@ class SparkContext(config: SparkConf) extends Logging

[GitHub] spark pull request #17091: [SPARK-19757][CORE] DriverEndpoint#makeOffers rac...

2017-03-06 Thread jxiang
Github user jxiang commented on a diff in the pull request: https://github.com/apache/spark/pull/17091#discussion_r104578056 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1646,7 +1646,7 @@ class SparkContext(config: SparkConf) extends Logging

[GitHub] spark issue #17091: [SPARK-19757][CORE] DriverEndpoint#makeOffers race again...

2017-03-06 Thread jxiang
Github user jxiang commented on the issue: https://github.com/apache/spark/pull/17091 @vanzin I updated the patch a little so as not to kill an executor if it is busy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark issue #17091: [SPARK-19757] DriverEndpoint#makeOffers race against Coa...

2017-03-05 Thread jxiang
Github user jxiang commented on the issue: https://github.com/apache/spark/pull/17091 Sure. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #17091: DriverEndpoint#makeOffers race against CoarseGrai...

2017-03-03 Thread jxiang
Github user jxiang commented on a diff in the pull request: https://github.com/apache/spark/pull/17091#discussion_r104214804 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -222,12 +222,17 @@ class

[GitHub] spark pull request #17091: [SPARK-19757][CORE] Executor with task scheduled ...

2017-02-27 Thread jxiang
GitHub user jxiang opened a pull request: https://github.com/apache/spark/pull/17091 [SPARK-19757][CORE] Executor with task scheduled could be killed due to idleness ## What changes were proposed in this pull request? In makeOffers, put in one synchronization block to check