[GitHub] spark pull request: [SPARK-13289][MLLIB] Fix infinite distances be...

2016-04-29 Thread jyshen15
Github user jyshen15 commented on a diff in the pull request: https://github.com/apache/spark/pull/11812#discussion_r61606066 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/feature/Word2VecSuite.scala --- @@ -108,5 +108,26 @@ class Word2VecSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-13289][MLLIB] Fix infinite distances be...

2016-04-19 Thread jyshen15
Github user jyshen15 commented on the pull request: https://github.com/apache/spark/pull/11812#issuecomment-211756190 i will handle the python style issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13289][MLLIB] Fix infinite distances be...

2016-03-23 Thread jyshen15
Github user jyshen15 commented on the pull request: https://github.com/apache/spark/pull/11812#issuecomment-200416321 @MLnick cool! It actually comes down to the question that what should the `getVectors ` outputs? If the equation ` getVectors("Paris") - getVecto