[GitHub] spark pull request: [SPARK-4808] Remove Spillable minimum threshol...

2014-12-10 Thread lawlerd
Github user lawlerd commented on a diff in the pull request: https://github.com/apache/spark/pull/3656#discussion_r21644679 --- Diff: core/src/main/scala/org/apache/spark/util/collection/Spillable.scala --- @@ -72,8 +69,7 @@ private[spark] trait Spillable[C] extends Logging

[GitHub] spark pull request: [SPARK-4808] Remove Spillable minimum threshol...

2014-12-10 Thread lawlerd
Github user lawlerd commented on the pull request: https://github.com/apache/spark/pull/3656#issuecomment-66538076 Thanks for the review, @andrewor14! I figured that to be the case. I weighed this against the hazard of OOMs and figured it was the lesser evil, but I might

[GitHub] spark pull request: [SPARK-4808] Remove Spillable minimum threshol...

2014-12-09 Thread lawlerd
GitHub user lawlerd opened a pull request: https://github.com/apache/spark/pull/3656 [SPARK-4808] Remove Spillable minimum threshold and sampling You can merge this pull request into a Git repository by running: $ git pull https://github.com/lawlerd/spark branch-1.2