[GitHub] spark pull request #23268: [SPARK-26319][SQL][Test] Add appendReadColumns Un...

2018-12-10 Thread maomaoChibei
Github user maomaoChibei commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240126376 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

2018-12-09 Thread maomaoChibei
Github user maomaoChibei commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240107003 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This