[GitHub] spark issue #18229: [SPARK-20691][CORE] Difference between Storage Memory as...

2017-06-07 Thread mkesselaers
Github user mkesselaers commented on the issue: https://github.com/apache/spark/pull/18229 @srowen, you're right. I changed the strings there as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #18229: [SPARK-20691][CORE] Difference between Storage Memory as...

2017-06-07 Thread mkesselaers
Github user mkesselaers commented on the issue: https://github.com/apache/spark/pull/18229 @srowen , I changed the variable names for `bytesToString`. As far as I see, this should be everything. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18229: [SPARK-20691][CORE] Difference between Storage Memory as...

2017-06-07 Thread mkesselaers
Github user mkesselaers commented on the issue: https://github.com/apache/spark/pull/18229 @srowen , I propose to rewrite the variable names of bytesToString as well, to be consistent. Other occurences of KB can be found in the ivy-report.xsl and in the ByteSuffixes

[GitHub] spark issue #18229: [SPARK-20691][CORE] Difference between Storage Memory as...

2017-06-07 Thread mkesselaers
Github user mkesselaers commented on the issue: https://github.com/apache/spark/pull/18229 OK, the tests are fixed to take this into account. BytesToString, now correctly output "KiB" instead of "KB" and utils.js now also calculates the correct value.

[GitHub] spark issue #18229: [SPARK-20691][CORE] Difference between Storage Memory as...

2017-06-07 Thread mkesselaers
Github user mkesselaers commented on the issue: https://github.com/apache/spark/pull/18229 @srowen , my apologies, I must have misunderstood you. I changed the calculation to be MebiBytes, but afterwards saw in the tests that the calculation was already correct ` test

[GitHub] spark pull request #18229: [SPARK-20691][CORE] Difference between Storage Me...

2017-06-07 Thread mkesselaers
GitHub user mkesselaers opened a pull request: https://github.com/apache/spark/pull/18229 [SPARK-20691][CORE] Difference between Storage Memory as seen internally and in web UI ## What changes were proposed in this pull request? Changed the Strings from MegaBytes