Github user mtustin-handy commented on the issue:
https://github.com/apache/spark/pull/12004
I don't see any downsides to this. At present working with s3 isn't super
painful, but I do see why one would want support to be better and smoother.
---
If your project is set up
Github user mtustin-handy commented on the pull request:
https://github.com/apache/spark/pull/12456#issuecomment-213037791
@jerryshao Makes sense. Would having an explicitly inheritable facility, or
a way to switch the spark context into inheritable mode (whatever that design
looks
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r58302077
--- Diff: core/src/main/scala/org/apache/spark/partial/BoundedDouble.scala
---
@@ -21,5 +21,23 @@ package org.apache.spark.partial
* A Double
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r58301694
--- Diff: core/src/main/scala/org/apache/spark/partial/BoundedDouble.scala
---
@@ -21,5 +21,23 @@ package org.apache.spark.partial
* A Double
Github user mtustin-handy commented on the pull request:
https://github.com/apache/spark/pull/12016#issuecomment-204781141
The only failure has been failing since this:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54771/.
I can pull from master and try
Github user mtustin-handy commented on the pull request:
https://github.com/apache/spark/pull/12016#issuecomment-204608558
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r58280956
--- Diff:
core/src/test/scala/org/apache/spark/partial/SumEvaluatorSuite.scala ---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r58227053
--- Diff:
core/src/test/scala/org/apache/spark/partial/SumEvaluatorSuite.scala ---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r58226959
--- Diff:
core/src/test/scala/org/apache/spark/partial/SumEvaluatorSuite.scala ---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r58143286
--- Diff:
core/src/test/scala/org/apache/spark/partial/SumEvaluatorSuite.scala ---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r57982008
--- Diff:
core/src/test/scala/org/apache/spark/partial/SumEvaluatorSuite.scala ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r57892280
--- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala
---
@@ -40,30 +41,39 @@ private[spark] class SumEvaluator(totalOutputs: Int
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r57889474
--- Diff:
core/src/test/scala/org/apache/spark/partial/SumEvaluatorSuite.scala ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r57733543
--- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala
---
@@ -40,30 +41,39 @@ private[spark] class SumEvaluator(totalOutputs: Int
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r57732083
--- Diff:
core/src/test/scala/org/apache/spark/partial/SumEvaluatorSuite.scala ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r57731787
--- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala
---
@@ -40,30 +41,39 @@ private[spark] class SumEvaluator(totalOutputs: Int
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r57726326
--- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala
---
@@ -40,30 +41,39 @@ private[spark] class SumEvaluator(totalOutputs: Int
GitHub user mtustin-handy opened a pull request:
https://github.com/apache/spark/pull/12016
[SPARK-14163][CORE] SumEvaluator and countApprox cannot reliably handle
RDDs of size 1
## What changes were proposed in this pull request?
This special cases 0 and 1 counts to avoid
Github user mtustin-handy closed the pull request at:
https://github.com/apache/spark/pull/11982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mtustin-handy commented on the pull request:
https://github.com/apache/spark/pull/11982#issuecomment-202611779
@rxin @srowen Looks like github is not showing the correct diff any more.
I'm going to close this, reopen and tag you.
---
If your project is set up for it, you
Github user mtustin-handy commented on the pull request:
https://github.com/apache/spark/pull/11982#issuecomment-202543675
I hit this with `countApprox`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/11982#discussion_r57529573
--- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala
---
@@ -56,9 +56,12 @@ private[spark] class SumEvaluator(totalOutputs: Int
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/11982#discussion_r57529558
--- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala
---
@@ -56,9 +56,12 @@ private[spark] class SumEvaluator(totalOutputs: Int
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/11982#discussion_r57529308
--- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala
---
@@ -56,9 +56,12 @@ private[spark] class SumEvaluator(totalOutputs: Int
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/11982#discussion_r57521152
--- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala
---
@@ -56,9 +56,12 @@ private[spark] class SumEvaluator(totalOutputs: Int
Github user mtustin-handy commented on a diff in the pull request:
https://github.com/apache/spark/pull/11982#discussion_r57521048
--- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala
---
@@ -56,9 +56,12 @@ private[spark] class SumEvaluator(totalOutputs: Int
GitHub user mtustin-handy opened a pull request:
https://github.com/apache/spark/pull/11982
[SPARK-14163][CORE] SumEvaluator and countApprox cannot reliably handle
RDDs of size 1
## What changes were proposed in this pull request?
This special cases 0 and 1 counts to avoid
27 matches
Mail list logo
