Github user nezihyigitbasi closed the pull request at:
https://github.com/apache/spark/pull/13863
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nezihyigitbasi commented on the issue:
https://github.com/apache/spark/pull/13863
@jiangxb1987 nope, I am not. Please go ahead if you want to take it over.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nezihyigitbasi commented on the issue:
https://github.com/apache/spark/pull/13863
@rxin I need to rebase, do more testing with all the new changes since my
PR, and someone should review it.
---
If your project is set up for it, you can reply to this email and have your
GitHub user nezihyigitbasi opened a pull request:
https://github.com/apache/spark/pull/13863
[SPARK-16158][CORE][WIP] Make dynamic allocation heuristics pluggable
## What changes were proposed in this pull request?
This WIP PR makes it possible to plug in custom dynamic
Github user nezihyigitbasi commented on the issue:
https://github.com/apache/spark/pull/13709
added javadoc for `getUserJars()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user nezihyigitbasi opened a pull request:
https://github.com/apache/spark/pull/13709
[SPARK-15782] [YARN] Fix spark.jars and spark.yarn.dist.jars handling
## What changes were proposed in this pull request?
When `--packages` is specified with spark-shell the classes
Github user nezihyigitbasi commented on the issue:
https://github.com/apache/spark/pull/13693
yep will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nezihyigitbasi commented on the issue:
https://github.com/apache/spark/pull/13693
@vanzin thanks for fixing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nezihyigitbasi commented on the issue:
https://github.com/apache/spark/pull/13527
@vanzin updated, thanks a lot for reviewing this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nezihyigitbasi commented on the issue:
https://github.com/apache/spark/pull/13527
@vanzin makes sense, updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nezihyigitbasi commented on a diff in the pull request:
https://github.com/apache/spark/pull/13527#discussion_r67046004
--- Diff:
repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -1071,8 +1071,16 @@ object SparkILoop extends Logging
Github user nezihyigitbasi commented on the issue:
https://github.com/apache/spark/pull/13527
thanks @vanzin, addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nezihyigitbasi commented on the issue:
https://github.com/apache/spark/pull/13527
@vanzin updated to address your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nezihyigitbasi commented on a diff in the pull request:
https://github.com/apache/spark/pull/13527#discussion_r66675499
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -444,6 +444,7 @@ object SparkSubmit {
OptionAssigner
Github user nezihyigitbasi commented on a diff in the pull request:
https://github.com/apache/spark/pull/13527#discussion_r65945574
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -444,6 +444,7 @@ object SparkSubmit {
OptionAssigner
GitHub user nezihyigitbasi opened a pull request:
https://github.com/apache/spark/pull/13527
[SPARK-15782] [CORE] Set spark.jars system property in client mode
## What changes were proposed in this pull request?
When `--packages` is specified with `spark-shell` the classes
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11865#issuecomment-212120928
@rxin tests look OK, do you have any other comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11865#issuecomment-211995362
@rxin somehow jenkins didn't start the tests after my last push, can you
please kick it off?
---
If your project is set up for it, you can reply to this email
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11865#issuecomment-211703836
Mima tests failing, I guess we can exclude them all. What do you think?
```Scala
[info] spark-core: found 3 potential binary incompatibilities while
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11865#issuecomment-211643260
@rxin thanks, comments addressed. Renamed that file to use lower-case too.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11865#issuecomment-211609869
@rxin thanks for the comments. Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nezihyigitbasi commented on a diff in the pull request:
https://github.com/apache/spark/pull/11865#discussion_r60145840
--- Diff: core/src/main/scala/org/apache/spark/rdd/CoalescedRDDPublic.scala
---
@@ -0,0 +1,47 @@
+/*
--- End diff --
I tried
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11865#issuecomment-211592037
@rxin rebased & addressed comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user nezihyigitbasi commented on a diff in the pull request:
https://github.com/apache/spark/pull/11865#discussion_r60137892
--- Diff: core/src/main/scala/org/apache/spark/rdd/CoalescedRDD.scala ---
@@ -70,21 +70,24 @@ private[spark] case class CoalescedRDDPartition
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11865#issuecomment-211568597
If the API changes look OK to you, then I don't have anything else before
this is not WIP. I only need to resolve conflicts with the master.
---
If your
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11865#issuecomment-211558139
@rxin any plans to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11865#issuecomment-205390556
@hbhanawat once we figure out the details I think it makes sense to do that.
---
If your project is set up for it, you can reply to this email and have your
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11865#issuecomment-204082776
@rxin any comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nezihyigitbasi commented on a diff in the pull request:
https://github.com/apache/spark/pull/11865#discussion_r56891755
--- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala ---
@@ -971,5 +1013,60 @@ class RDDSuite extends SparkFunSuite
GitHub user nezihyigitbasi opened a pull request:
https://github.com/apache/spark/pull/11865
[SPARK-14042][CORE] Add custom coalescer support [WIP]
## What changes were proposed in this pull request?
This is a work-in-progress PR (to gather feedback) about a new feature
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-195098262
@andrewor14 got rid of the whitespaces. Thanks everyone for their reviews.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-195096647
@andrewor14 just saw it and also rebased (seems like some changes have been
pushed to master).
---
If your project is set up for it, you can reply
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-195075443
@andrewor14 @tgravescs @squito guys I believe this is ready to get in. Do
you have any other comments?
---
If your project is set up for it, you can reply
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-195023960
@andrewor14 comments addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-194965029
@tgravescs OK made it a config parameter
(`spark.block.failures.beforeLocationRefresh` with a default of 5). After we
hit this problem I have deployed this fix
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-194560497
@squito thanks for the review, addressed your comments. I think the only
thing that is left to merge this issue is to reach consensus on whether we want
to make
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-194455011
@andrewor14 rebased. I agree with @tgravescs that this should be
configurable (which was the case in my initial PR) but I am also fine as long
as we get
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-191389153
@andrewor14 do you have any other comments for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-187793223
@andrewor14 addressed your comments && tests have passed, can you please
take a look?
---
If your project is set up for it, you can reply to th
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-187319511
@andrewor14 addressed your comments, can you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-186444001
@andrewor14 thanks for taking a look. We can introduce a global failure
threshold to break out, but do we really want that global threshold to be a
constant
Github user nezihyigitbasi commented on a diff in the pull request:
https://github.com/apache/spark/pull/11241#discussion_r53531237
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1263,4 +1263,44 @@ class BlockManagerSuite extends
Github user nezihyigitbasi commented on a diff in the pull request:
https://github.com/apache/spark/pull/11241#discussion_r53530728
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -575,6 +582,18 @@ private[spark] class BlockManager
Github user nezihyigitbasi commented on a diff in the pull request:
https://github.com/apache/spark/pull/11241#discussion_r53529534
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -135,6 +135,11 @@ private[spark] class BlockManager
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/8216#issuecomment-186426131
@andrewor14 @davies guys any plans to get this in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nezihyigitbasi commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-186400398
Updated to fix the style problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nezihyigitbasi commented on a diff in the pull request:
https://github.com/apache/spark/pull/11241#discussion_r53203126
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -135,6 +135,10 @@ private[spark] class BlockManager
GitHub user nezihyigitbasi opened a pull request:
https://github.com/apache/spark/pull/11241
[SPARK-13328][Core]: Poor read performance for broadcast variables with
dynamic resource allocation
When dynamic resource allocation is enabled fetching broadcast variables
from removed
48 matches
Mail list logo
