[GitHub] spark pull request: SPARK-2368 Making FileServerHandler sends grac...

2014-09-03 Thread ngbinh
Github user ngbinh closed the pull request at: https://github.com/apache/spark/pull/1303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-2368 Making FileServerHandler sends grac...

2014-09-03 Thread ngbinh
Github user ngbinh commented on the pull request: https://github.com/apache/spark/pull/1303#issuecomment-54400440 I agree that these changes look outdated now. I believe Akka-http streaming http://typesafe.com/blog/typesafe-announces-akka-streams is the future. I remember

[GitHub] spark pull request: SPARK-2367: update io.netty from 4.0.17 to 4.0...

2014-08-14 Thread ngbinh
Github user ngbinh closed the pull request at: https://github.com/apache/spark/pull/1302 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-2367: update io.netty from 4.0.17 to 4.0...

2014-08-14 Thread ngbinh
Github user ngbinh commented on the pull request: https://github.com/apache/spark/pull/1302#issuecomment-52275260 thanks. closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: SPARK-2368 Making FileServerHandler sends grac...

2014-07-07 Thread ngbinh
Github user ngbinh commented on the pull request: https://github.com/apache/spark/pull/1303#issuecomment-48264696 @mridulm please take another look. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-2368 Making FileServerHandler sends grac...

2014-07-04 Thread ngbinh
Github user ngbinh commented on a diff in the pull request: https://github.com/apache/spark/pull/1303#discussion_r14559944 --- Diff: core/src/main/java/org/apache/spark/network/netty/FileServerHandler.java --- @@ -80,4 +78,11 @@ public void exceptionCaught(ChannelHandlerContext

[GitHub] spark pull request: SPARK-2368 Making FileServerHandler sends grac...

2014-07-04 Thread ngbinh
GitHub user ngbinh opened a pull request: https://github.com/apache/spark/pull/1303 SPARK-2368 Making FileServerHandler sends gracefully to prevent OOM Busy wait for the channel to be ready before writing to it to prevent the buffer from exploding. Also making some

[GitHub] spark pull request: SPARK-2367: update io.netty from 4.0.17 to 4.0...

2014-07-04 Thread ngbinh
GitHub user ngbinh opened a pull request: https://github.com/apache/spark/pull/1302 SPARK-2367: update io.netty from 4.0.17 to 4.0.21 pretty big performance improvement and some bug fixes. More details: http://netty.io/news/2014/07/01/4.html You can merge this pull request into