Github user patrickmcgloin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199696129
--- Diff: python/pyspark/sql/functions.py ---
@@ -2163,9 +2163,9 @@ def json_tuple(col, *fields):
@since(2.1)
def from_json(col, schema
Github user patrickmcgloin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199356020
--- Diff: python/pyspark/sql/functions.py ---
@@ -2163,9 +2163,9 @@ def json_tuple(col, *fields):
@since(2.1)
def from_json(col, schema
Github user patrickmcgloin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199350374
--- Diff: python/pyspark/sql/functions.py ---
@@ -2163,9 +2163,9 @@ def json_tuple(col, *fields):
@since(2.1)
def from_json(col, schema
Github user patrickmcgloin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199342794
--- Diff: python/pyspark/sql/functions.py ---
@@ -2163,9 +2163,9 @@ def json_tuple(col, *fields):
@since(2.1)
def from_json(col, schema
Github user patrickmcgloin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199342210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -317,16 +292,52 @@ class JacksonParser
Github user patrickmcgloin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199330240
--- Diff: python/pyspark/sql/functions.py ---
@@ -2163,9 +2163,9 @@ def json_tuple(col, *fields):
@since(2.1)
def from_json(col, schema
Github user patrickmcgloin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199330156
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -43,6 +43,11 @@ private[sql] class
Github user patrickmcgloin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199319281
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -163,6 +175,22 @@ private[sql] class
Github user patrickmcgloin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199319246
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -163,6 +175,22 @@ private[sql] class
Github user patrickmcgloin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199316164
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -317,16 +292,52 @@ class JacksonParser
GitHub user patrickmcgloin opened a pull request:
https://github.com/apache/spark/pull/21671
[SPARK-24682] [SQL] from_json / to_json now handle java.sql.Date/Timestamp
as Map key
## What changes were proposed in this pull request?
When generating JSON the key is not just
Github user patrickmcgloin commented on the issue:
https://github.com/apache/spark/pull/21670
This is mistake. I have not put the correct code changes with the pull
request. Will close.
---
-
To unsubscribe, e
Github user patrickmcgloin closed the pull request at:
https://github.com/apache/spark/pull/21670
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user patrickmcgloin opened a pull request:
https://github.com/apache/spark/pull/21670
[SPARK-24682] [SQL] from_json / to_json now handle java.sql.Date/Timestamp
as Map key
## What changes were proposed in this pull request?
When generating JSON the key is not just
Github user patrickmcgloin closed the pull request at:
https://github.com/apache/spark/pull/20946
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user patrickmcgloin reopened a pull request:
https://github.com/apache/spark/pull/20946
[SPARK-23565] [SS] New error message for structured streaming sources
assertion
## What changes were proposed in this pull request?
A more informative message to tell you why
Github user patrickmcgloin commented on the issue:
https://github.com/apache/spark/pull/20946
Hi @xuanyuanking, please see comments above.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user patrickmcgloin commented on the issue:
https://github.com/apache/spark/pull/20946
Hi Xuan,
I have updated the title, removed the extra white space after the period /
dot and removed the UT
GitHub user patrickmcgloin opened a pull request:
https://github.com/apache/spark/pull/20946
[SPARK-23565] [SQL] New error message for structured streaming sources
assertion
## What changes were proposed in this pull request?
A more informative message to tell you why
19 matches
Mail list logo
