[GitHub] spark issue #14807: [SPARK-17256][Deploy, Windows]Check before adding double...

2016-08-28 Thread qualiu
Github user qualiu commented on the issue: https://github.com/apache/spark/pull/14807 @tritab : Thanks for your reply! Yes, I had tried that last week but not forgot to put them on the context. (1) Has space in `spark-submit.cmd` full path. (2) Cut off quoted argument no

[GitHub] spark issue #14807: [SPARK-17256][Deploy, Windows]Check before adding double...

2016-08-28 Thread qualiu
Github user qualiu commented on the issue: https://github.com/apache/spark/pull/14807 @tsudukim : I did the validation mentioned above and snap the picture as following: ![image](https://cloud.githubusercontent.com/assets/18525294/18038476/4bbbdea8-6dcb-11e6-8dd3-07cae45cdada.png

[GitHub] spark issue #14807: [Deploy, Windows]Check before adding double quotes in sp...

2016-08-25 Thread qualiu
Github user qualiu commented on the issue: https://github.com/apache/spark/pull/14807 @srowen @tsudukim @tritab @andrewor14 : Hello, I've updated to a more conservative fix, please review it, thanks! I didn't push [my former fix]( https://github.com/qualiu/spark/tree/

[GitHub] spark issue #14807: Remove double quotes in spark/bin batch files to avoid c...

2016-08-25 Thread qualiu
Github user qualiu commented on the issue: https://github.com/apache/spark/pull/14807 @srowen : Thank you! Glad to hear opinions and maybe need more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14807: Remove double quotes in spark/bin batch files to avoid c...

2016-08-25 Thread qualiu
Github user qualiu commented on the issue: https://github.com/apache/spark/pull/14807 @srowen : Sorry that there's something misleading in my example about the --jar. The key points in short are : * The double quotes with **spark-submit.cmd** doesn't work** i

[GitHub] spark issue #14807: Remove double quotes in spark/bin batch files to avoid c...

2016-08-25 Thread qualiu
Github user qualiu commented on the issue: https://github.com/apache/spark/pull/14807 And what's more, current `spark-submit.cmd` will cause an extra error of **"The input line is too long."** if you call `spark-submit.cmd` in an batch file under some case ```

[GitHub] spark issue #14807: Remove double quotes in spark/bin batch files to avoid c...

2016-08-25 Thread qualiu
Github user qualiu commented on the issue: https://github.com/apache/spark/pull/14807 @srowen : thanks for your reply. But as I've mentioned above , path with spaces is not work now: ``` D:\opengit\spark\bin - Copy>spark-submit.cmd --jars just-to-start &qu

[GitHub] spark pull request #14807: Remove double quotes in spark/bin batch files to ...

2016-08-25 Thread qualiu
GitHub user qualiu opened a pull request: https://github.com/apache/spark/pull/14807 Remove double quotes in spark/bin batch files to avoid cutting off arguments that double quoted as contain special character. ## What changes were proposed in this pull request? Remove