Github user raghavgautam closed the pull request at:
https://github.com/apache/spark/pull/22414
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@srowen Ok. I will close this PR and the bug.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@srowen Can you give examples ? From what I have seen, invalid values
because of typo say `1 sec` throw exception at groupby
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@srowen Key benefit is fail fast particularly when running from spark-shell.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r223865925
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala
---
@@ -137,16 +139,44 @@ object TimeWindow
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r223853069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala
---
@@ -137,16 +139,44 @@ object TimeWindow
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@maropu Can you take a look ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r220380587
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala
---
@@ -122,6 +123,51 @@ class TimeWindowSuite
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r220380561
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala
---
@@ -137,16 +139,42 @@ object TimeWindow
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
The problem is that the error message that we start getting is:
```
requirement failed: The window duration must be positive, but found:
-12096
```
Where as the error
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@maropu Please continue with the review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r218613023
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala
---
@@ -35,6 +35,10 @@ case class TimeWindow
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r218530222
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala
---
@@ -122,6 +123,51 @@ class TimeWindowSuite
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@maropu I have updated the PR description and answered your question, can
you continue with your review.
---
-
To
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r218153205
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala
---
@@ -35,6 +35,10 @@ case class TimeWindow
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@maropu Can you continue with the review ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
The code below throws following error. Note that the error is produced at
the time of count() call instead of window() call.
```java
val df = spark.readStream
.format("
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r217793474
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala
---
@@ -122,11 +122,57 @@ class TimeWindowSuite
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r217793345
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala
---
@@ -122,11 +122,57 @@ class TimeWindowSuite
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r217793214
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala
---
@@ -35,29 +35,15 @@ case class TimeWindow
Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r217793251
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala
---
@@ -122,11 +122,57 @@ class TimeWindowSuite
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@tdas Can you please take a look ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user raghavgautam opened a pull request:
https://github.com/apache/spark/pull/22414
[SPARK-25424][SQL] Window duration and slide duration with negative vâ¦
â¦alues should fail fast
(Link to Jira: https://issues.apache.org/jira/browse/SPARK-25424)
## What
23 matches
Mail list logo
