Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/4034#issuecomment-70321016
@pwendell, that sounds like a good decision. Thanks for letting me know!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/4034#issuecomment-70218446
Took a little longer on an old computer, but I made sure it built
successfully this time. Should hopefully be good to go now.
---
If your project is set up for it
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/4034#issuecomment-70215690
Whoops, missed adding an import for the DeveloperApi on _SparkCommandLine_.
Give me a minute to add it.
---
If your project is set up for it, you can reply to this
GitHub user rcsenkbeil opened a pull request:
https://github.com/apache/spark/pull/4034
[REPL][SPARK-4923] Add Developer API to REPL to allow re-publishing the
REPL jar
As requested in
[SPARK-4923](https://issues.apache.org/jira/browse/SPARK-4923), I've provided a
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53626590
@mateiz Created an account located at
https://issues.apache.org/jira/secure/ViewProfile.jspa?name=senkwich
---
If your project is set up for it, you can reply to
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53566931
@ScrapCodes, this was the case that I said I didn't support since the
likelihood of bringing in different jars with the same package structure and
class names is
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53512263
Awesome! Great find, @heathermiller! I've added an additional commit to
move to that solution. @mateiz, what do you think now? This is what Global
itself do
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53506313
@mateiz I've added a hack that just runs a compilation error in silence
before adding anything to allow this. It works as seen here (and doesn't
inte
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53377066
I've been fiddling around in the debugger to try to see if I can pinpoint
what occurs during a compile error that would affect the state of Global,
considering
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53369528
Ah, it appears that I run into your issue when I create a class in Scala
and attempt to import. My previous tests had been with Java.
So, when I use code like
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53369372
@mateiz I have not run into that issue. In fact, I just cloned a copy of my
branch I submitted on a fresh computer and it still worked fine.
To test, I cloned
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-52651504
@heathermiller Thanks for the feedback! It looks like @gkossakowski
commented here:
[SI-6052](https://issues.scala-lang.org/browse/SI-6502?focusedCommentId=70407&
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-52309557
@mateiz @som-snytt The summary I have is that this should work for 2.10.x
as it doesn't appear like they are trickling the removal of the class
invalidation
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-52190737
@ScrapCodes I recently picked up Scala and am much more familiar with
Java's reflection than Scala's runtime mirrors and such. Do you have any pseudo
code
Github user rcsenkbeil commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-52117091
@mateiz I don't know what the Scala team's plans would be. I know that the
only suggestion thus far was to wipe the global reference and recreate
Github user rcsenkbeil commented on a diff in the pull request:
https://github.com/apache/spark/pull/1929#discussion_r16208310
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkIMain.scala ---
@@ -130,6 +131,9 @@ import org.apache.spark.util.Utils
private var
Github user rcsenkbeil commented on a diff in the pull request:
https://github.com/apache/spark/pull/1929#discussion_r16206874
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkIMain.scala ---
@@ -308,6 +312,56 @@ import org.apache.spark.util.Utils
Github user rcsenkbeil commented on a diff in the pull request:
https://github.com/apache/spark/pull/1929#discussion_r16206505
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkIMain.scala ---
@@ -130,6 +131,9 @@ import org.apache.spark.util.Utils
private var
Github user rcsenkbeil commented on a diff in the pull request:
https://github.com/apache/spark/pull/1929#discussion_r16206403
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -711,22 +714,22 @@ class SparkILoop(in0: Option[BufferedReader],
protected val
Github user rcsenkbeil commented on a diff in the pull request:
https://github.com/apache/spark/pull/1929#discussion_r16206386
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -711,22 +714,22 @@ class SparkILoop(in0: Option[BufferedReader],
protected val
GitHub user rcsenkbeil opened a pull request:
https://github.com/apache/spark/pull/1929
Added support for :cp that was broken in Scala 2.10.x for REPL
As seen with [SI-6502](https://issues.scala-lang.org/browse/SI-6502) of
Scala, the _:cp_ command was broken in Scala 2.10.x. As
21 matches
Mail list logo
