Github user rdelassus commented on the issue:
https://github.com/apache/spark/pull/14640
There is an infinite number of ways to make folds. Until now we had the
mlutils kfold. You want to add the groupedKfold. But I don't think we should
add one by one every folding method that can be useful, thus adding (like you
did) "if my method else if this othermethod [...] else kfold". It would be far
better to make the folding method independant from the crossvalidator class,
and pass it as an argument for example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
