[GitHub] spark pull request #20790: AccumulatorV2 subclass isZero scaladoc fix

2018-03-09 Thread smallory
GitHub user smallory opened a pull request: https://github.com/apache/spark/pull/20790 AccumulatorV2 subclass isZero scaladoc fix Added/corrected scaladoc for isZero on the DoubleAccumulator, CollectionAccumulator, and LongAccumulator subclasses of AccumulatorV2, particularly

[GitHub] spark issue #20790: [SPARK-23642][DOCS] AccumulatorV2 subclass isZero scalad...

2018-03-13 Thread smallory
Github user smallory commented on the issue: https://github.com/apache/spark/pull/20790 Thanks for the pointer on the title convention, the way the contributing doc distinguished code and documentation changes left me a bit puzzled as to what actually applied to this change

[GitHub] spark pull request #20790: [SPARK-23642][DOCS] AccumulatorV2 subclass isZero...

2018-03-13 Thread smallory
Github user smallory commented on a diff in the pull request: https://github.com/apache/spark/pull/20790#discussion_r174225748 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -290,7 +290,8 @@ class LongAccumulator extends AccumulatorV2[jl.Long