[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-10-08 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-146665724 Test passes. Any feedback on this? Or can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-22 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-142287774 This fixes pyspark tests. Please test this again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-21 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-142152718 Please test this again - there were some github connection issue --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-21 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-142093257 Ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-20 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-141793243 Jenkins please test again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-15 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-140479983 @davies ping Can somebody verify this? Jenkins have't started tests for this pull requests --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-11 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-139605916 @mengxr, @davies thanks for a hints I'm rather new with Scala, and very interested into learning it further. I've found the code with Python wrapper used

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-11 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-139653064 Ok Please see this update - I've added methods for converting Tuple to Array into MatrixFactorizationModelWrapper Could you please review this pull

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-10 Thread smartkiwi
GitHub user smartkiwi opened a pull request: https://github.com/apache/spark/pull/8700 [SPARK-10535] Sync up API for matrix factorization model between Scala and PySpark Support for recommendUsersForProducts and recommendProductsForUsers in matrix factorization model for PySpark

[GitHub] spark pull request: [SPARK-10535] Sync up API for matrix factoriza...

2015-09-10 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/8700#issuecomment-139398333 I've added these methods doc string Acually it is not that useful as it is now - as it returns "scala.Tuple2" strings - and not as in scala (Int, Ar

[GitHub] spark pull request: [SPARK-8528] Expose SparkContext.applicationId...

2015-06-27 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/6936#issuecomment-116164420 Python doctests are rather limited in expressiveness, but efficient in keeping examples bug free in documentation. Anywhere - here is another patch that works

[GitHub] spark pull request: [SPARK-8528] Expose SparkContext.applicationId...

2015-06-27 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/6936#issuecomment-116163405 Thanks for hints Retesting locally with python3 and python2. I will push update in ~30 minutes --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-8528] Expose SparkContext.applicationId...

2015-06-26 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/6936#issuecomment-115709427 Hm, looks like last test haven't honored ELLIPSIS. Anyway this is doctest is not particularly useful. The contents of the applicationId is set outside of the test

[GitHub] spark pull request: [SPARK-8528] Expose SparkContext.applicationId...

2015-06-26 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/6936#issuecomment-115713640 Please test updated version - I made the doctest stable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-8528] Expose SparkContext.applicationId...

2015-06-23 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/6936#issuecomment-114516593 Done updating docstrings. Thank you for suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-8528] Expose SparkContext.applicationId...

2015-06-23 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/6936#issuecomment-114621840 Interesting build results - not tests failed, but whole build timeouted --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-8528] Expose SparkContext.applicationId...

2015-06-23 Thread smartkiwi
Github user smartkiwi commented on the pull request: https://github.com/apache/spark/pull/6936#issuecomment-114695860 Jenkins, please test it again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-8528] add applicationId property for Sp...

2015-06-22 Thread smartkiwi
GitHub user smartkiwi opened a pull request: https://github.com/apache/spark/pull/6936 [SPARK-8528] add applicationId property for SparkContext object in pyspark. Use case - we want to log applicationId (YARN in hour case) to request help with troubleshooting from

[GitHub] spark pull request: SPARK-5633 pyspark saveAsTextFile support for ...

2015-02-05 Thread smartkiwi
GitHub user smartkiwi opened a pull request: https://github.com/apache/spark/pull/4403 SPARK-5633 pyspark saveAsTextFile support for compression codec See https://issues.apache.org/jira/browse/SPARK-5633 for details You can merge this pull request into a Git repository by running