Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
In this case the change is simpler to understand in prose, I think; "100
KB" becomes "97.6 KiB", etc.
---
---
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23275#discussion_r240234573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -47,25 +47,13 @@ case class ScalaUDF
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23275#discussion_r240234371
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -47,25 +47,13 @@ case class ScalaUDF
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23260
Ok, got it. @vanzin or @squito or others would be better able to evaluate.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23072
@dongjoon-hyun @felixcheung how about now?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23260
If you're on YARN, this feels like something you would manage via YARN and
its cluster management options. Is there a specific use case here, that this
has to happen in Spark
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23263
My first impression is that it's a big change, which is reason for caution
here.
Visualizing a workflow is nice, but Spark's Pipelines are typically pretty
straightforward and linear. I
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23241
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
Fortunately the syntax is "100m", which has always meant "100 * 1024 *
1024" or "100 MiB"
---
-
T
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/23264
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/23264
Update to Scala 2.12.8
## What changes were proposed in this pull request?
Back-port of https://github.com/apache/spark/pull/23218 ; updates Scala
2.12 build to 2.12.8
## How
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23218
Merged to master. I'll open a separate PR for branch-2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/23218
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239990036
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -161,6 +161,10 @@ private void writeSortedFile(boolean
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23256
CC @felixcheung
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23160
Merged to master. @shahidki31 does this need to go in branch 2.4, 2.3? I
tried back porting it, but looks like a lot of the affected code didn't exist
in 2.4. If the fix can or should also be back
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23247
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17673
@ngopal this one can't be merged as-is and looks like it was abandoned.
Would you like to take this PR, update per reviews? I'd review that. I think
CBOW could be useful in MLlib
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23218
I'm not sure. I can't find any other reference to this crash and 2.12.8. It
could be something only Spark happens to trigger, or could be specific to this
JVM + platform but not Spark or Scala. We
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23241
Sorry about the run-around. I'm OK being conservative here as you were
originally, too.
---
-
To unsubscribe, e-mail: reviews
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23246
It's not clear this is where it should be from the description. Please
review https://spark.apache.org/contributing.html This one should be closed
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23247
These aren't worth the time it takes us to review them and merge them,
honestly. Little cleanup can be OK if it makes an appreciable difference in
speed or readability, and if you can find many
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23241#discussion_r239590339
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala ---
@@ -118,8 +118,6 @@ private[spark] class ReplayListenerBus extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23241#discussion_r239532748
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala ---
@@ -118,10 +118,12 @@ private[spark] class ReplayListenerBus extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23241#discussion_r239525888
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala ---
@@ -118,10 +118,12 @@ private[spark] class ReplayListenerBus extends
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23202
I'd defer to @HyukjinKwon ; looks OK in broad strokes but he would know
much more about the CSV parsing.
---
-
To unsubscribe, e
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23241#discussion_r239509724
--- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala ---
@@ -197,4 +201,8 @@ class ZStdCompressionCodec(conf: SparkConf) extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22683#discussion_r239482033
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NullExpressionsSuite.scala
---
@@ -160,7 +160,7 @@ class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22683#discussion_r239480795
--- Diff:
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
@@ -62,14 +62,14 @@ class KryoSerializer(conf: SparkConf
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22683#discussion_r239481508
--- Diff: docs/sql-programming-guide.md ---
@@ -4,10 +4,15 @@ displayTitle: Spark SQL, DataFrames and Datasets Guide
title: Spark SQL and DataFrames
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23241#discussion_r239476570
--- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala ---
@@ -197,4 +201,8 @@ class ZStdCompressionCodec(conf: SparkConf) extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23241#discussion_r239476672
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala ---
@@ -118,8 +118,6 @@ private[spark] class ReplayListenerBus extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22759#discussion_r239474962
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -542,6 +551,35 @@ class DataFrameReaderWriterSuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22759#discussion_r239475332
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -542,6 +551,35 @@ class DataFrameReaderWriterSuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22759#discussion_r239475203
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -542,6 +551,35 @@ class DataFrameReaderWriterSuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23241#discussion_r239218209
--- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala ---
@@ -197,4 +201,8 @@ class ZStdCompressionCodec(conf: SparkConf) extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23228#discussion_r239215561
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala ---
@@ -33,10 +33,10 @@ import org.apache.spark.shuffle._
* Sort
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23241#discussion_r239208072
--- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala ---
@@ -197,4 +201,8 @@ class ZStdCompressionCodec(conf: SparkConf) extends
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23231
I'm not seeing it in the migration guide, maybe I'm missing it. In any
event, I dont' think we need to keep this for 3.0
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23229
Agree, this isn't worthwhile.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23196#discussion_r239068840
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -49,8 +49,8 @@ class
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23218
Ah OK, so all of them were a JVM crash. It would probably be a good idea to
update the JVM on all the workers as _60 is over 3 years old. It's probably not
as simple as it sounds but WDYT
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23218
Hm, one failure was due to a JVM crash, but it fails twice consistent, with
sbt just exiting with status 134. No other failures are logged. Not sure what
to make
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23216
I think just leave it. The `@transient` in `ShuffleMapTasks`'s `locs` is
just superfluous here, not sure it's worth changing
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23216
Are you sure it's even a field in the class? it looks like it's only used
to define this:
```
@transient private[this] val preferredLocs: Seq[TaskLocation] = {
if (locs == null
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23159#discussion_r238869530
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1777,7 +1777,7 @@ class Analyzer(
case
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23159
Rather than change every single call to this method, if this should
generally be the value of the argument, then why not make it the default value
or something
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23219
@wangyum I already opened https://github.com/apache/spark/pull/23218
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22759
Ping @dima-asana to rebase or close
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21363
@MaxGekk now that your change is merge, can this proceed, @xuanyuanking ?
or is it obsolete?
---
-
To unsubscribe, e-mail
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22997
Yeah, we can't make this change for the reasons above.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22887
@gjhkael can you clarify further what the undesirable behavior is, and what
behavior you are looking for?
---
-
To unsubscribe
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23098
Note I'm holding on to this PR for a while as I understand it might be
disruptive to downstream builds to remove 2.11 support just now. Will look at
merging it in weeks. Right now it's an FYI
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23150
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23218
Hm, looks like genjavadocplugin is published for individual Scala releases
and doesn't exist yet for 2.12.8:
https://mvnrepository.com/artifact/com.typesafe.genjavadoc/genjavadoc-plugin .
I'll look
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23170
Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22600
@wangyum sounds good. I opened https://github.com/apache/spark/pull/23218
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/23218
[SPARK-26266][BUILD] Update to Scala 2.12.8
## What changes were proposed in this pull request?
Update to Scala 2.12.8
## How was this patch tested?
Existing tests.
You
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23182
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23189
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18784
@skonto do you want to proceed with this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
Add to this PR. The change goes logically together.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23205
Merging as a follow up to https://github.com/apache/spark/pull/21688
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23164
OK merged to 2.4/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r238110710
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -148,11 +148,20 @@ private[spark] class AppStatusStore
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r238110723
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -221,29 +230,49 @@ private[spark] class AppStatusStore
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22683#discussion_r238102080
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1164,17 +1164,17 @@ private[spark] object Utils extends Logging {
} else
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23164
I just mean, is this a bug that comes up otherwise in Spark? should this be
back-ported or is it just supporting the new change you reference? I can merge
to master at least
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23150
It makes sense that parsing depends on a timezone, though that's set as an
option in the parser typically. The tests should generally test "GMT" for this
reason. If there's a default
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238073218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23162
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23178#discussion_r238062995
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -38,114 +38,106 @@ import
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23177
Merging to master. I've been using 3.6.0 on the command line for a while
and it's fine. Note that if you use your local mvn in IntelliJ, it seems to
have some incompatibility with the current latest
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23185
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23146#discussion_r237888294
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/loss/DifferentiableRegularizationSuite.scala
---
@@ -16,9 +16,13 @@
*/
package
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23146#discussion_r237888645
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -250,6 +250,66 @@ private[classification] trait
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23146#discussion_r237888349
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/loss/DifferentiableRegularizationSuite.scala
---
@@ -16,9 +16,13 @@
*/
package
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23146#discussion_r237888585
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -250,6 +250,66 @@ private[classification] trait
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r237886340
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -105,5 +105,16 @@ abstract class SparkFunSuite
logInfo(s"
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r237886193
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -105,5 +105,16 @@ abstract class SparkFunSuite
logInfo(s"
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237883918
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237884151
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23177#discussion_r237881557
--- Diff: pom.xml ---
@@ -114,7 +114,7 @@
1.8
${java.version}
${java.version}
-3.5.4
+3.6.0
--- End diff
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23162#discussion_r237880921
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -513,7 +513,7 @@ package object config {
"is wr
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23148
Yeah we'd need a new PR. If you collect a few good improvements just open a
follow up. I was testing by just making a dummy change in a few files and
seeing what it did. It's OK as-is, even
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23177
Ah, that's the second time I've forgotten this. Yes looks good to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23126
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23148
I played with this a little locally, and yeah it does reformat entire files
that are in the diff, and most of what it does is fixing stuff we probably
wouldn't ask for in a PR review. For example
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23145
I think this is fine to merge, this is a good batch of grammar fixes.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23145#discussion_r237564429
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1634,7 +1634,7 @@ returned through `Dataset.writeStream()`. You will
have to specify one
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23162#discussion_r237563687
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -503,7 +503,7 @@ package object config {
"made in cre
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23162#discussion_r237563435
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -430,8 +430,8 @@ package object config {
.doc("The chunk
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23148
Ah I see. I can add that call in a follow-up to enable it and see how we
like it.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23052
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237561245
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/OutputWriter.scala
---
@@ -57,6 +57,9 @@ abstract class OutputWriterFactory
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r237559695
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
@@ -66,6 +66,20 @@ private[sql] trait SQLTestUtils extends SparkFunSuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r237559321
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -494,13 +494,12 @@ class SparkSubmitSuite
}
test
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23177
That's fine but we need to also update build/mvn to download and use the
same version.
---
-
To unsubscribe, e-mail: reviews
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23126#discussion_r237556042
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala
---
@@ -128,6 +128,82 @@ class RowMatrix @Since("
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23126#discussion_r237541497
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala
---
@@ -128,6 +128,82 @@ class RowMatrix @Since("
1 - 100 of 15282 matches
Mail list logo