Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/17090#discussion_r104036563
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -594,6 +595,95 @@ class ALSSuite
Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/17090#discussion_r104013729
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -594,6 +595,95 @@ class ALSSuite
Github user sueann commented on the issue:
https://github.com/apache/spark/pull/17090
The output in https://github.com/apache/spark/pull/12574/ looks like a
DataFrame with Row(srcCol: Int, "recommendations": Array[(Int, Float)]) so I
think this PR as is matches the o
Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/17090#discussion_r103366357
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -285,6 +285,43 @@ class ALSModel private[ml] (
@Since("
Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/17090#discussion_r103366071
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -248,18 +248,18 @@ class ALSModel private[ml] (
@Since("
Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/17090#discussion_r103350775
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -248,18 +248,18 @@ class ALSModel private[ml] (
@Since("
Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/17090#discussion_r103350410
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/recommendation/TopByKeyAggregator.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache
Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/17090#discussion_r103349139
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/recommendation/TopByKeyAggregator.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache
GitHub user sueann opened a pull request:
https://github.com/apache/spark/pull/17090
[Spark-19535][ML] RecommendForAllUsers RecommendForAllItems for ALS on
Dataframe
## What changes were proposed in this pull request?
This is a simple implementation
Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/17090#discussion_r103349080
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/recommendation/TopByKeyAggregator.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache
GitHub user sueann opened a pull request:
https://github.com/apache/spark/pull/16860
[SPARK-18613][ML] make spark.mllib LDA dependencies in spark.ml LDA private
## What changes were proposed in this pull request?
spark.ml.*LDAModel classes were exposing spark.mllib LDA models
Github user sueann commented on the issue:
https://github.com/apache/spark/pull/16480
Now the logs show the full class path for the
estimator/evaluator/classifier:
```
INFO Instrumentation: CrossValidator-cv_acb968c4de59-968285285-1:
{"esti
Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/16480#discussion_r94870250
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala ---
@@ -85,9 +86,27 @@ private[spark] class Instrumentation[E <: Estima
Github user sueann commented on the issue:
https://github.com/apache/spark/pull/16480
Unit test runs & logs:
* TrainValidationSplit
```
$ build/sbt "test-only
org.apache.spark.ml.tuning.TrainValidationSplitSuiteâ
$ less mllib/target/unit-
GitHub user sueann opened a pull request:
https://github.com/apache/spark/pull/16480
[SPARK-18194][ML] Log instrumentation in OneVsRest, CrossValidator,
TrainValidationSplit
## What changes were proposed in this pull request?
Added instrumentation logging for OneVsRest
Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/16480#discussion_r94859428
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -344,6 +344,10 @@ final class OneVsRest @Since("
Github user sueann commented on the issue:
https://github.com/apache/spark/pull/16480
@jkbradley @thunterdb
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
17 matches
Mail list logo
