[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...

2015-04-29 Thread szheng79
Github user szheng79 commented on the pull request: https://github.com/apache/spark/pull/5754#issuecomment-97485938 @srowen I say it is with SPARK-6994, because the implementation must based on SPARK-6994 change. And because this is a very minor change, I don't want to hijack

[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...

2015-04-29 Thread szheng79
Github user szheng79 commented on the pull request: https://github.com/apache/spark/pull/5754#issuecomment-97477450 I just think it is best for a java developer has more specific way to control the return type. Like current there is these version of methods to access row by index

[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...

2015-04-28 Thread szheng79
GitHub user szheng79 opened a pull request: https://github.com/apache/spark/pull/5754 [SPARK-6994]Add helper methods to access by field This is a trial change, is useful in java (because java developer can't benefit from getAs[T] method). You can merge this pull request into

[GitHub] spark pull request: JDBCRDD: Add to support on type NVARCHAR

2015-04-22 Thread szheng79
Github user szheng79 commented on a diff in the pull request: https://github.com/apache/spark/pull/5618#discussion_r28876804 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRDD.scala --- @@ -60,6 +60,7 @@ private[sql] object JDBCRDD extends Logging

[GitHub] spark pull request: Add support on type NVARCHAR

2015-04-21 Thread szheng79
GitHub user szheng79 opened a pull request: https://github.com/apache/spark/pull/5618 Add support on type NVARCHAR Issue: https://issues.apache.org/jira/browse/SPARK-7039 Add support to column type NVARCHAR in Sql Server You can merge this pull request into a Git