Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173420746
Thank you for merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173107263
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-167196430
I modified some mistakes that was pointed out in #8534.
@mengxr Could you take a look?
---
If your project is set up for it, you can reply to this email and have
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-162819270
Thank you for merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-162440255
I modified the code that was pointed out.
@sarutak @yu-iskw Thank you for reviewing!
---
If your project is set up for it, you can reply to this email and have
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161939914
Thank you for reviewing.
I'm modifying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user taishi-oss commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46671245
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -155,10 +155,13 @@ private[classification] trait
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-161544658
in Pipeline.scala, I have some questions.
1.
for example, Pipeline.fit was introduced in v1.2.0.
but, signature was changed in v1.4.0
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-161544578
@yu-iskw Sorry for being late, I modify my miss and add anotation to all
public class, object, methods, and variables.
---
If your project is set up for it, you can
Github user taishi-oss commented on a diff in the pull request:
https://github.com/apache/spark/pull/8935#discussion_r46520868
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-156377905
I modified the code that was pointed out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-156359833
@yu-iskw Sorry for being late, I'm do right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-153615685
Sorry for being late.
I rebased this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-153612968
Sorry for being late.
I rebased this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-144666719
@mengxr Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user taishi-oss opened a pull request:
https://github.com/apache/spark/pull/8935
[SPARK-10263] [ML] Add @Since annotation to ml.param and ml.*
Add Since annotations to ml.param and ml.*
You can merge this pull request into a Git repository by running:
$ git pull https
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-141008317
I think DecisionTreeClassifer.copy is introduced in v1.5.0.
but, This method is brought into v.1.4.1 using "git-cherry-pick".
So "git blames&qu
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-140677301
@mengxr Could you take a look?
Now, I'm adding Since annotation to ml.classification.
I think DecisionTreeClassifer.copy is introduced in [this
c
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-140334039
I think [that
commit](https://github.com/taishi-oss/spark/commit/43c7ec6384e51105dedf3a53354b6a3732cc27b2)
is right.
but "git show" command results
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-140026675
Sorry, I misunderstood.
I check when all methods were introduced and modify it.
(use SPARK-7751 as a reference.)
If it is not my mistake
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-139132076
I'm sorry for taking your time.
I modified the code that was pointed out.
---
If your project is set up for it, you can reply to this email and have your
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-138488219
Sorry for being late.
I modified @since annotations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user taishi-oss opened a pull request:
https://github.com/apache/spark/pull/8534
[SPARK-10259] [ML] Add @since annotation to ml.classification
Add @since annotation to ml.classification
You can merge this pull request into a Git repository by running:
$ git pull https
Github user taishi-oss closed the pull request at:
https://github.com/apache/spark/pull/8327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8327#issuecomment-132899417
@mengxr Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user taishi-oss opened a pull request:
https://github.com/apache/spark/pull/8327
[SPARK-10127] [MLlib] Add numpy-like indexing
Currently, we don't have good interface to access sub-matrix.
It's inconvenience to prototype manipulate matrix via spark-shell for t
26 matches
Mail list logo
