Github user taku-k commented on the pull request:
https://github.com/apache/spark/pull/12767#issuecomment-219938151
@MLnick Thanks! My JIRA username is `taku-k`. It's the same as the github
username.
---
If your project is set up for it, you can reply to this email and have your
Github user taku-k commented on a diff in the pull request:
https://github.com/apache/spark/pull/12767#discussion_r63323853
--- Diff: python/pyspark/ml/tests.py ---
@@ -594,17 +594,21 @@ def test_fit_minimize_metric(self):
iee = InducedErrorEstimator
Github user taku-k commented on a diff in the pull request:
https://github.com/apache/spark/pull/12767#discussion_r62420020
--- Diff: python/pyspark/ml/tests.py ---
@@ -645,6 +651,37 @@ def test_save_load(self):
self.assertEqual(loadedLrModel.intercept
Github user taku-k commented on the pull request:
https://github.com/apache/spark/pull/12767#issuecomment-217337159
@MLnick Thank you. I rebased to latest master and resolved conflicts. I
would like you to review my Pull/Req.
---
If your project is set up for it, you can reply
Github user taku-k commented on the pull request:
https://github.com/apache/spark/pull/12767#issuecomment-215640922
cc @feynmanliang @jkbradley @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user taku-k commented on a diff in the pull request:
https://github.com/apache/spark/pull/12767#discussion_r61536791
--- Diff: python/pyspark/ml/tests.py ---
@@ -586,10 +589,13 @@ def test_fit_maximize_metric(self):
tvsModel = tvs.fit(dataset
Github user taku-k commented on a diff in the pull request:
https://github.com/apache/spark/pull/12767#discussion_r61536588
--- Diff: python/pyspark/ml/tests.py ---
@@ -616,6 +622,7 @@ def test_save_load(self):
tvsModel.save(tvsModelPath)
loadedModel
Github user taku-k commented on a diff in the pull request:
https://github.com/apache/spark/pull/12767#discussion_r61536420
--- Diff: python/pyspark/ml/tuning.py ---
@@ -613,7 +615,9 @@ def copy(self, extra=None):
"""
i
GitHub user taku-k opened a pull request:
https://github.com/apache/spark/pull/12767
[SPARK-14978][PySpark] PySpark TrainValidationSplitModel should support
validationMetrics
## What changes were proposed in this pull request?
This pull request includes supporting
