[GitHub] spark issue #16966: [SPARK-18409][ML]LSH approxNearestNeighbors should use a...

2017-04-13 Thread urvishparikh
Github user urvishparikh commented on the issue: https://github.com/apache/spark/pull/16966 Ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2015-11-06 Thread urvishparikh
Github user urvishparikh commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-154524005 Yes I agree @mengxr that much is definitely true. If we make that change here then we also have to make that corresponding change in the scala version. --- If

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2015-11-06 Thread urvishparikh
Github user urvishparikh commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-154516022 Yes but for consistency sake (and for ensuring sortedness which is crucial for SparseVector to function) I think the >= condition is fine. --- If your project

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2015-11-06 Thread urvishparikh
Github user urvishparikh commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-154510035 @yu-iskw The indices are sorted within the code base at: https://github.com/apache/spark/blob/master/python/pyspark/mllib/linalg/__init__.py#L510 So