[GitHub] spark pull request: [SPARK-11710] Document new memory management m...

2015-11-13 Thread vidaha
Github user vidaha commented on a diff in the pull request: https://github.com/apache/spark/pull/9676#discussion_r44828910 --- Diff: docs/tuning.md --- @@ -88,9 +88,40 @@ than the "raw" data inside their fields. This is due to several reasons: but also pointers (t

[GitHub] spark pull request: [SPARK-11710] Document new memory management m...

2015-11-13 Thread vidaha
Github user vidaha commented on a diff in the pull request: https://github.com/apache/spark/pull/9676#discussion_r44828509 --- Diff: docs/tuning.md --- @@ -88,9 +88,40 @@ than the "raw" data inside their fields. This is due to several reasons: but also pointers (t

[GitHub] spark pull request: [SPARK-3752][SQL]: Add tests for different UDF...

2014-10-06 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2621#issuecomment-58083951 @marmbrus - ready for another round - merge or let me know what to change. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-3752][SQL]: Add tests for different UDF...

2014-10-06 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2621#issuecomment-58072165 okay to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-3752][SQL]: Add tests for different UDF...

2014-10-03 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2621#issuecomment-57851949 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-3752][SQL]: Add tests for different UDF...

2014-10-03 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2621#issuecomment-57848035 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-3752][SQL]: Add tests for different UDF...

2014-10-02 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2621#issuecomment-57718220 Please hold off on merging - I want to add more cases to this test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-3752][SQL]: Add tests for different UDF...

2014-10-01 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2621#issuecomment-57549956 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-3752][SQL]: Add tests for different UDF...

2014-10-01 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2621#issuecomment-57538418 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: Add tests for different UDF's

2014-10-01 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2621#issuecomment-57537146 @marmbrus I would expect some of these test cases to fail...any idea why it isn't? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: Add tests for different UDF's

2014-10-01 Thread vidaha
GitHub user vidaha opened a pull request: https://github.com/apache/spark/pull/2621 Add tests for different UDF's You can merge this pull request into a Git repository by running: $ git pull https://github.com/vidaha/spark vida/SPARK-3752 Alternatively you can revie

[GitHub] spark pull request: SPARK-3608 Break if the instance tag naming su...

2014-09-19 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2466#issuecomment-56243604 @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: SPARK-3608 Break if the instance tag naming su...

2014-09-19 Thread vidaha
GitHub user vidaha opened a pull request: https://github.com/apache/spark/pull/2466 SPARK-3608 Break if the instance tag naming succeeds You can merge this pull request into a Git repository by running: $ git pull https://github.com/vidaha/spark vida/spark-3608 Alternatively

[GitHub] spark pull request: Spark-3213 Fixes issue with spark-ec2 not dete...

2014-08-27 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2163#issuecomment-53643387 Awesome - thanks - sorry that took a long time, but I think we have settled on the right long term solution IMHO! --- If your project is set up for it, you can reply to

[GitHub] spark pull request: Spark-3213 Fixes issue with spark-ec2 not dete...

2014-08-27 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2163#issuecomment-53639952 @jkbradley one more time - i mixed up state and status. ugh. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: Spark-3213 Fixes issue with spark-ec2 not dete...

2014-08-27 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2163#issuecomment-53636942 @jkbradley Oh right - I launched with this version of the script as well...updated - please try one more time - fingers crossed! --- If your project is set up

[GitHub] spark pull request: Spark-3213 Fixes issue with spark-ec2 not dete...

2014-08-27 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2163#issuecomment-53626372 @JoshRosen Yes, this pull request does fix that issue. Although it was not the "Name" tag that was causing the problem - I still made that cha

[GitHub] spark pull request: Add a spark-cluster-tag tag instead of overloa...

2014-08-27 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/2163#issuecomment-53624455 @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: Add a spark-cluster-tag tag instead of overloa...

2014-08-27 Thread vidaha
GitHub user vidaha opened a pull request: https://github.com/apache/spark/pull/2163 Add a spark-cluster-tag tag instead of overloading the cluster name, and... ... copy the spark_cluster_tag from a spot instance requests over to the instances. You can merge this pull request into

[GitHub] spark pull request: SPARK-2333 - spark_ec2 script should allow opt...

2014-08-18 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/1899#issuecomment-52576663 Okay, I made the retry a try catch, and edited the title again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-2333

2014-08-13 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/1899#issuecomment-52134043 Great - I made the small edits, and adding a loop for retrying the tagging logic. I tested to see if I can bring up a cluster, and it went up fine - it didn'

[GitHub] spark pull request: Vida/ec2 reuse security group

2014-08-12 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/1899#issuecomment-51949860 Hi Josh, IMHO, it's best not to require a Spark cluster name and the security group to be the same. While you can reuse an existing security group to l

[GitHub] spark pull request: Vida/ec2 reuse security group

2014-08-11 Thread vidaha
Github user vidaha commented on the pull request: https://github.com/apache/spark/pull/1899#issuecomment-51865214 Just FYI - I tested this and it worked - not sure if it's controversial to use the name tag rather than the group for destroy a cluster. --- If your project is s

[GitHub] spark pull request: Vida/ec2 reuse security group

2014-08-11 Thread vidaha
GitHub user vidaha opened a pull request: https://github.com/apache/spark/pull/1899 Vida/ec2 reuse security group You can merge this pull request into a Git repository by running: $ git pull https://github.com/vidaha/spark vida/ec2-reuse-security-group Alternatively you can