[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r198079703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2289,6 +2292,401 @@ case class Flatten

[GitHub] spark issue #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on the issue: https://github.com/apache/spark/pull/21155 please retest --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197714164 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2288,6 +2288,401 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197496354 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -308,6 +313,292 @@ class

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197496293 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -308,6 +313,292 @@ class

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197496187 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197496245 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197485470 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197477593 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r197465469 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1887,6 +1889,402 @@ case class Flatten

[GitHub] spark issue #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on the issue: https://github.com/apache/spark/pull/21155 Any other comments on this one? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21401: [SPARK-24350][SQL] "array_position" error fix

Github user wajda commented on the issue: https://github.com/apache/spark/pull/21401 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21395: [SPARK-24348][SQL] "element_at" error fix

Github user wajda commented on the issue: https://github.com/apache/spark/pull/21395 Yep, just have fixed that one as well :) https://github.com/apache/spark/pull/21401 --- - To unsubscribe, e-mail: reviews

[GitHub] spark pull request #21401: SPARK-24350 "array_position" error fix

GitHub user wajda opened a pull request: https://github.com/apache/spark/pull/21401 SPARK-24350 "array_position" error fix ## What changes were proposed in this pull request? Fixes ```ClassCastException``` in the ```array_position``` function ## How was

[GitHub] spark pull request #21395: SPARK-24348 "element_at" error fix

GitHub user wajda opened a pull request: https://github.com/apache/spark/pull/21395 SPARK-24348 "element_at" error fix ## What changes were proposed in this pull request? Fixes a ```scala.MatchError``` in the "element_at" operation ## How w

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r187309647 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1468,3 +1472,388 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r187280683 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1468,3 +1472,388 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r187277937 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1468,3 +1472,388 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r187195445 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -536,6 +536,15 @@ object TypeCoercion

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186479450 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186134394 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark issue #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on the issue: https://github.com/apache/spark/pull/21155 Regarding ```step, stop, step``` vs. ```arg1, arg2, arg3```, ```left, middle, right``` and so on. Originally I used those to avoid hiding variables from the outer scope, but after the final

[GitHub] spark issue #21155: [SPARK-23927][SQL] Add "sequence" expression

Github user wajda commented on the issue: https://github.com/apache/spark/pull/21155 Thanks you for the comments. I'll review and make changes shortly. --- - To unsubscribe, e-mail: reviews-uns

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r184130293 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,282 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

GitHub user wajda opened a pull request: https://github.com/apache/spark/pull/21155 SPARK-23927: Add "sequence" expression ## What changes were proposed in this pull request? The PR adds the SQL function ```sequence```. https://issues.apache.org/jira/browse/S

[GitHub] spark pull request #20938: [SPARK-23821][SQL] Collection function: flatten

Github user wajda commented on a diff in the pull request: https://github.com/apache/spark/pull/20938#discussion_r181379483 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,160 @@ case class