[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...

2016-09-05 Thread wilson-lauw
Github user wilson-lauw commented on the issue: https://github.com/apache/spark/pull/14219 Closing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #14219: [SPARK-16566][MLLib] sort sparseVector's indices ...

2016-09-05 Thread wilson-lauw
Github user wilson-lauw closed the pull request at: https://github.com/apache/spark/pull/14219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...

2016-07-17 Thread wilson-lauw
Github user wilson-lauw commented on the issue: https://github.com/apache/spark/pull/14219 Modifications also needed on module mllib-local, file org.apache.spark.ml.linalg.Vectors.scala. Once the changes is okay, I will also apply the changes there. --- If your project is set up

[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...

2016-07-17 Thread wilson-lauw
Github user wilson-lauw commented on the issue: https://github.com/apache/spark/pull/14219 @hhbyyh I just checked, the implementation of `def dot(x: SparseVector, y: SparseVector)` also need to be modified. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...

2016-07-17 Thread wilson-lauw
Github user wilson-lauw commented on the issue: https://github.com/apache/spark/pull/14219 file org.apache.spark.ml.linalg.BLAS.scala on module mllib-local also need to be fixed, once the changes is okay, I will also apply the changes there. --- If your project is set up for it, you

[GitHub] spark pull request #14219: [SPARK-16566][MLLib] sort sparseVector's indices ...

2016-07-17 Thread wilson-lauw
Github user wilson-lauw commented on a diff in the pull request: https://github.com/apache/spark/pull/14219#discussion_r71086805 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala --- @@ -617,8 +617,27 @@ private[spark] object BLAS extends Serializable

[GitHub] spark pull request #14219: sort sparseVector's indices before doing multipli...

2016-07-15 Thread wilson-lauw
GitHub user wilson-lauw opened a pull request: https://github.com/apache/spark/pull/14219 sort sparseVector's indices before doing multiplication ## What changes were proposed in this pull request? sort sparseVector's indices before doing multiplication to make sure