[GitHub] spark pull request: [SPARK-3176] Implement 'ABS and 'LAST' for sql

Github user xinyunh commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-55043188 Why it fails while I only changed the name of title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-3176] Implement 'ABS and 'LAST' for sql

Github user xinyunh commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-54663384 Sorry, I forgot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

Github user xinyunh commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-54342991 I have split the POWER to PR #2252, Jira number is 3379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-3379] Implement 'POWER' for sql

GitHub user xinyunh opened a pull request: https://github.com/apache/spark/pull/2252 [SPARK-3379] Implement 'POWER' for sql Add support for the mathematical function "POWER" within spark sql. Test-cases included. Spitted from [SPARK-3176]. You can merge th

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

Github user xinyunh commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-54336477 OK. Thus, I should remove the POWER part from this pull request and create another pull request which includes the POWER, correct? Need I also split the issue on Jira

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

Github user xinyunh commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-54186634 Thank you! Fixed this code style issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

Github user xinyunh commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-54184220 May I know in which test cases do we failed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

Github user xinyunh commented on the pull request: https://github.com/apache/spark/pull/2099#issuecomment-53941443 I have made some changes according to the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

Github user xinyunh commented on a diff in the pull request: https://github.com/apache/spark/pull/2099#discussion_r16923739 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numericOperations.scala --- @@ -0,0 +1,78 @@ +package

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

Github user xinyunh commented on a diff in the pull request: https://github.com/apache/spark/pull/2099#discussion_r16923732 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numericOperations.scala --- @@ -0,0 +1,78 @@ +package

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

Github user xinyunh commented on a diff in the pull request: https://github.com/apache/spark/pull/2099#discussion_r16923711 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala --- @@ -323,6 +328,10 @@ class SqlParser extends StandardTokenParsers

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

Github user xinyunh commented on a diff in the pull request: https://github.com/apache/spark/pull/2099#discussion_r16923701 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala --- @@ -409,3 +424,15 @@ case class FirstFunction(expr

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

Github user xinyunh commented on a diff in the pull request: https://github.com/apache/spark/pull/2099#discussion_r16923632 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numericOperations.scala --- @@ -0,0 +1,78 @@ +package

[GitHub] spark pull request: [SPARK-3176] Implement 'POWER', 'ABS and 'LAST...

GitHub user xinyunh opened a pull request: https://github.com/apache/spark/pull/2099 [SPARK-3176] Implement 'POWER', 'ABS and 'LAST' for sql Add support for the mathematical function "POWER" and "ABS" and the analytic function "

[GitHub] spark pull request: SPARK-3111 Implement the LAST analytic functio...

Github user xinyunh closed the pull request at: https://github.com/apache/spark/pull/2025 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-3111 Implement the LAST analytic functio...

GitHub user xinyunh opened a pull request: https://github.com/apache/spark/pull/2025 SPARK-3111 Implement the LAST analytic function for sql SPARK-3111 Implement the LAST analytic function for sql You can merge this pull request into a Git repository by running: $ git pull