Github user yjshen closed the pull request at:
https://github.com/apache/spark/pull/8200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yjshen closed the pull request at:
https://github.com/apache/spark/pull/8224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10628#discussion_r49151061
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/10628#issuecomment-169646900
Is this PR the first step to enable vectorized execution in Spark SQL or
just for efficient serialization to use external components?
---
If your project is set up for
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166491984
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166480126
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166268307
@marmbrus @maropu @gatorsmile I've update my PR to add CNFNormalization
into the Optimizer. I'm so sorry for the delay in my reply.
---
If your project is set
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48133669
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -489,13 +511,13 @@ object BooleanSimplification extends
Github user yjshen closed the pull request at:
https://github.com/apache/spark/pull/8742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8742#issuecomment-141873047
Thanks @yhuai, I'll close this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-140610959
@marmbrus converting a filter into CNF may lead to an expanded filter,
which I think is not necessarily a general optimisation.
---
If your project is set up for it
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-140396062
It seems when test build triggered for multiple times in a row, only the
first test build would fail and all subsequent builds success.
---
If your project is set up
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-140318454
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-140315135
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-140306774
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-140303172
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-140303230
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-140303129
I'll trigger more test build now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-140303246
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-140302922
After exploring all the build failure above, Mysql test only fails with
`Image pull failed`, Postgres test would fail due to `create container` or
`pull image`.
---
If
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8742#discussion_r39478700
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -136,26 +136,12 @@ object SetOperationPushDown extends
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8224#discussion_r39468018
--- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/Interval.java
---
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Foundation
GitHub user yjshen reopened a pull request:
https://github.com/apache/spark/pull/8742
[SPARK-10539][SQL]Fix set optimization by eliminate empty project list push
down
Push down empty project list through `Intersect` or `Except` would make all
the rows in both child to empty row
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8742#issuecomment-140075395
I need to investigate more about set operator to make sure I'm doing the
right thing. Close it for now.
---
If your project is set up for it, you can reply to
Github user yjshen closed the pull request at:
https://github.com/apache/spark/pull/8742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-140010260
Since #5700 has been merged, I would revert the PR to its original version,
without De Morgan's laws
---
If your project is set up for it, you can reply to this
GitHub user yjshen opened a pull request:
https://github.com/apache/spark/pull/8742
[SPARK-10539][SQL]Fix set optimization by eliminate empty project list push
down
Push down empty project list through `Intersect` or `Except` would make all
the rows in both child to empty row
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-138497422
Sorry for my late reply.
MySQLIntegrationSuite would fail with:
```
Error Message
Image pull failed: mysql:latest: ProgressMessage{id=null, status
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-137017268
Pull mysql image would sometimes fail even with 5 retry...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-136964226
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-136963840
I'd like to trigger the build multiple times to make sure it works.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-136962566
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-136962226
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-136962036
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-136959971
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-136911936
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8353#discussion_r37693607
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -114,8 +114,44 @@ case class ConcatWs(children
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8353#discussion_r37693546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -114,8 +114,44 @@ case class ConcatWs(children
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8353#discussion_r37693511
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -114,8 +114,44 @@ case class ConcatWs(children
GitHub user yjshen opened a pull request:
https://github.com/apache/spark/pull/8353
[SPARK-9401][SQL]Fully implement code generation for ConcatWs
This PR adds full codegen support for ConcatWs, is a substitute of #7782
JIRA: https://issues.apache.org/jira/browse/SPARK-9401
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-133324454
@liancheng , is the current version OK to you? seems you didn't see the
updates.
---
If your project is set up for it, you can reply to this email and have your
Github user yjshen closed the pull request at:
https://github.com/apache/spark/pull/8165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yjshen closed the pull request at:
https://github.com/apache/spark/pull/8274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8274#discussion_r37487469
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -582,6 +582,109 @@ case class StringLocate
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-132187082
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8165#issuecomment-132185339
:) yes, I also think its a long one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user yjshen opened a pull request:
https://github.com/apache/spark/pull/8274
[SPARK-9400][SQL]Codegen for StringLocate
This PR implements the codegen for StringLocate and specialise the case
when str/start is foldable.
JIRA: https://issues.apache.org/jira/browse
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-132119747
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8165#issuecomment-132119614
@marmbrus @liancheng, Is this PR useful? I'm doing this because
https://github.com/apache/spark/pull/8157#issuecomment-130536937
---
If your project is set up f
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8224#issuecomment-132110127
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8224#issuecomment-132028817
Rebased to bring it up to date.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r37155062
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -501,6 +501,10 @@ object BooleanSimplification extends
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-131649820
@liancheng, do you mind to review this again? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/7855#issuecomment-131648962
jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/7855#issuecomment-131644728
unrelated failure,
org.apache.spark.sql.hive.HiveSparkSubmitSuite.SPARK-8368: includes jars passed
in through --jars
---
If your project is set up for it, you can
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/7855#issuecomment-131644336
jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user yjshen opened a pull request:
https://github.com/apache/spark/pull/8224
[SPARK-9431][SQL]TimeIntervalType for for time intervals
TimeIntervalType is stored as Long internally, represents the number of
microseconds and can be used in equality tests and ordering
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-131384508
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-131380851
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-131355373
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/7855#issuecomment-131314557
@JoshRosen , I've changed my implementation, do you mind review this again?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-131305062
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-131293018
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r37095602
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed to
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r37083228
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed to
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r37082551
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed to
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-131119885
Thanks @liancheng , I will update my PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r37078486
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -59,6 +59,30 @@ trait PredicateHelper
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8201#issuecomment-131107262
yes, it's the same, I mistakenly deleted them both on github, and reopened
a new PR here
---
If your project is set up for it, you can reply to this email and have
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-131096250
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-131095570
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-131095288
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-131094463
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8201#issuecomment-131092850
@rxin @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8201#issuecomment-131092056
I mistakenly delete the branch on github, sorry about this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user yjshen opened a pull request:
https://github.com/apache/spark/pull/8201
[SPARK-8887][SQL]Explicit define which data types can be used as dynamic
partition columns
This PR enforce dynamic partition column data type requirements by adding
analysis rules.
JIRA
GitHub user yjshen opened a pull request:
https://github.com/apache/spark/pull/8200
[SPARK-6624][SQL]Convert filters into CNF for data sources
This PR aims at converting filters into CNF, i.e. AND of ORs. By doing
this, we can possibly push more filters into datasource
Github user yjshen closed the pull request at:
https://github.com/apache/spark/pull/8132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yjshen closed the pull request at:
https://github.com/apache/spark/pull/8193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8193#issuecomment-131024720
cc @rxin @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user yjshen opened a pull request:
https://github.com/apache/spark/pull/8193
[SPARK-6624][SQL]Convert filters into CNF for data sources
This PR aims at converting filters into CNF, i.e. AND of ORs. By doing
this, we can possibly push more filters into datasource
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8165#issuecomment-130906309
@marmbrus @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user yjshen opened a pull request:
https://github.com/apache/spark/pull/8165
[SPARK-9938][SQL]Constant folding of binaryComparison on IntegralType
We would get a chance to do constant folding when we are comparing a
IntegerType column with Long Literal.
JIRA: https
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-130608592
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8132#discussion_r36959382
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -270,6 +271,18 @@ private[sql] object
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8132#discussion_r36957526
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -270,6 +271,18 @@ private[sql] object
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-130593254
pull `mysql` docker image would sometimes fail:
```
Exception encountered when attempting to run a suite with class name
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8132#issuecomment-130591739
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8132#issuecomment-130586521
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-130586263
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8132#discussion_r36950167
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ResolvedDataSource.scala
---
@@ -179,6 +179,13 @@ object ResolvedDataSource
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8132#discussion_r36950083
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala
---
@@ -554,6 +556,21 @@ abstract class HadoopFsRelationTest
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8132#discussion_r36950026
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala
---
@@ -554,6 +556,21 @@ abstract class HadoopFsRelationTest
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8157#issuecomment-130541000
@liancheng , I'm really sorry for my mistake.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8157#issuecomment-130536937
`select * from inttypes where A > 2147483648`, it would produce
`GreaterThan(Cast(A, LongType), Literal(2147483648L, LongType)`, in #8049 I
just cast the long value
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8132#discussion_r36938827
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -270,6 +270,8 @@ private[sql] object
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-130519516
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8101#issuecomment-130518768
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user yjshen opened a pull request:
https://github.com/apache/spark/pull/8157
[SPARK-9927][SQL]Revert 8049 since it's pushing wrong filter down
I made a mistake in #8049 by casting literal value to attribute's data
type, which would cause simply truncate the literal
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8049#discussion_r36936990
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -343,31 +343,57 @@ private[sql] object
1 - 100 of 243 matches
Mail list logo