[GitHub] spark pull request: [SPARK-11611][MLlib][Python] Python API for bi...

2016-04-04 Thread yu-iskw
Github user yu-iskw closed the pull request at: https://github.com/apache/spark/pull/9583 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-12874][ML] ML StringIndexer does not pr...

2016-02-25 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/11370 [SPARK-12874][ML] ML StringIndexer does not protect itself from column name duplication ## What changes were proposed in this pull request? ML StringIndexer does not protect itself from column

[GitHub] spark pull request: [SPARK-13292][ML][PYTHON] QuantileDiscretizer ...

2016-02-24 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/11362#issuecomment-188610588 @mengxr can you review it when you have time? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13292][ML][PYTHON] QuantileDiscretizer ...

2016-02-24 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/11362 [SPARK-13292][ML][PYTHON] QuantileDiscretizer should take random seed in PySpark ## What changes were proposed in this pull request? QuantileDiscretizer in Python should also specify a random

[GitHub] spark pull request: [SPARK-13265][ML] Refactoring of basic ML impo...

2016-02-11 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/11151#issuecomment-182865831 cc @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13265][ML] Refactoring of basic ML impo...

2016-02-11 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/11151#issuecomment-183116192 Thank you for merging it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2016-02-11 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-183115660 Thank you for merging it. I will do the issue. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13265][ML] Refactoring of basic ML impo...

2016-02-10 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/11151 [SPARK-13265][ML] Refactoring of basic ML import/export for other file system besides HDFS @jkbradley I tried to improve the function to export a model. When I tried to export a model to S3 under

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2016-02-10 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-182366711 @jkbradley ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6519][ML] Add spark.ml API for bisectin...

2016-01-20 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9604#issuecomment-173415286 Thank you for merging it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6519][ML] Add spark.ml API for bisectin...

2016-01-20 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9604#issuecomment-173152191 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...

2016-01-19 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/10831 [SQL][Minor] DigestUtils.shaHex is deprecated in misc.scala Since `DigestUtils.shaHex` is deprecated, we should replace `shaHex` with `sha1Hex`. You can merge this pull request into a Git

[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...

2016-01-19 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/10831#issuecomment-172788036 @JoshRosen sorry, thank you for letting me know. I'll close this PR. Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...

2016-01-19 Thread yu-iskw
Github user yu-iskw closed the pull request at: https://github.com/apache/spark/pull/10831 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2016-01-19 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/9535#discussion_r50203290 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -23,8 +23,8 @@ import org.apache.spark.Logging import

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2016-01-19 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-173062339 @jkbradley I have rebased with master. Can you review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-6519][ML] Add spark.ml API for bisectin...

2016-01-19 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9604#issuecomment-173055593 Sure! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12404] [SQL] Ensure objects passed to S...

2015-12-17 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/10357#issuecomment-165461189 @sarutak thank you for sending this PR. @marmbrus @rxin could you review it? I think this is a little big issue. We should fix it before releasing Spark 1.6

[GitHub] spark pull request: [SPARK-6518][MLlib][Example][DOC] Add example ...

2015-12-16 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-165277966 Thank you for merging it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9694] [ML] Add random seed Param to Sca...

2015-12-16 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9108#issuecomment-165277685 Thank you for merging this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12215][ML][DOC] User guide section for ...

2015-12-15 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/10244#issuecomment-164964860 @jkbradley thank you so much for the review. I modified the 2 points. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-6518][MLlib][Example][DOC] Add example ...

2015-12-15 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-164966445 @jkbradley thanks for the review. I modified the wrong indentations and excluded the import statements for `SparkConf` and `JavaSparkContext`. --- If your project

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2015-12-14 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-164631771 I have rebased this PR with master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2015-12-14 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-164604399 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6518][MLlib][Example][DOC] Add example ...

2015-12-13 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-164341602 Oh, I'm terribly sorry about that. Pushing the update was failed - Modified what you pointed out - Add a Java example and its doc --- If your project

[GitHub] spark pull request: [SPARK-12215][ML][DOC] User guide section for ...

2015-12-13 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/10244#issuecomment-164365254 @jkbradley thank you for reviewing it. I modified some a few points. Can you review it again? - Include the import statments of JavaKMeansExample in the doc

[GitHub] spark pull request: [SPARK-6518][MLlib][Example][DOC] Add example ...

2015-12-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-163487878 ping @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12215][ML][DOC] User guide section for ...

2015-12-09 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/10244 [SPARK-12215][ML][DOC] User guide section for KMeans in spark.ml cc @jkbradley You can merge this pull request into a Git repository by running: $ git pull https://github.com/yu-iskw/spark

[GitHub] spark pull request: [SPARK-12215][ML][DOC] User guide section for ...

2015-12-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/10244#issuecomment-163487655 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12215][ML][DOC] User guide section for ...

2015-12-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/10244#issuecomment-163488306 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

2015-12-04 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161946643 @sarutak thank you for your help! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6518][MLlib][Example] Add example code ...

2015-12-04 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-161983105 @jkbradley ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10266][Documentation, ML] Fixed @Since ...

2015-12-02 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9338#issuecomment-161460435 Thank you for merging it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6518][MLlib][Example] Add example code ...

2015-12-02 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-161466765 I moved the documentation to this PR from https://github.com/apache/spark/pull/9968. Because the PR depends on this PR. I modified the docs for `BisectingKMeans

[GitHub] spark pull request: [SPARK-6518][MLlib][DOC] Add example code and ...

2015-12-02 Thread yu-iskw
Github user yu-iskw closed the pull request at: https://github.com/apache/spark/pull/9968 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-6518][MLlib][DOC] Add example code and ...

2015-12-02 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9968#issuecomment-161466498 @jkbradley finally, I want to merge this PR with https://github.com/apache/spark/pull/9952. Because this PR depends on the example code. --- If your project is set up

[GitHub] spark pull request: [SPARK-10266][Documentation, ML] Fixed @Since ...

2015-12-02 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9338#issuecomment-161301469 I'll fix them soon! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6518][MLlib][Example] Add example code ...

2015-11-26 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-160012938 All right. I'll fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6518][MLlib][Example] Add example code ...

2015-11-26 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-160019724 @jkbradley could you review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6518][MLlib][DOC] Add example code and ...

2015-11-26 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/9968#discussion_r46012436 --- Diff: data/mllib/sample_bisecting_kmeans_data.txt --- @@ -0,0 +1,20 @@ +6.4,2.7,5.3,1.9 --- End diff -- Yes, we can. The reason why I

[GitHub] spark pull request: [SPARK-6518][MLlib][DOC] Add example code and ...

2015-11-25 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/9968 [SPARK-6518][MLlib][DOC] Add example code and user guide for bisecting k-means cc @jkbradley This PR relates to https://github.com/apache/spark/pull/9952. You can merge this pull request

[GitHub] spark pull request: [WIP][SPARK-11602] [MLlib] Refine visibility f...

2015-11-24 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r45815661 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.rdd.RDD

[GitHub] spark pull request: [SPARK-10266][Documentation, ML] Fixed @Since ...

2015-11-24 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9338#issuecomment-159444594 Sure. I'll resolve the conflicts by rebaseing master. Just a minute! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-10266][Documentation, ML] Fixed @Since ...

2015-11-24 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9338#issuecomment-159457312 @jkbradley I have rebased master. @noel-smith could you take a look when you have time? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-6518][MLlib] Add example code and user ...

2015-11-24 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/9952 [SPARK-6518][MLlib] Add example code and user guide for bisecting k-means This PR includes only an example code in order to finish it quickly. I'll send another PR for the docs soon. You can

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

2015-11-24 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-159466727 @taishi-oss thank you for the udpate! LGTM @jkbradley could you take a look at PR? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...

2015-11-24 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8935#issuecomment-159466857 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...

2015-11-24 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8935#issuecomment-159467655 @taishi-oss thank you for your contribution. Could you modify this PR like https://github.com/apache/spark/pull/8534? We should add the annotation to all public class

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

2015-11-24 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-159468625 @jkbradley could you run tests for this PR? This is the fist PR for @taishi-oss. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-6518][MLlib] Add example code and user ...

2015-11-24 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-159470079 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6518][MLlib] Add example code and user ...

2015-11-24 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-159474623 @jkbradley could you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Minor] Remove unnecessary spaces in `include_...

2015-11-24 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/9960 [Minor] Remove unnecessary spaces in `include_example.rb` You can merge this pull request into a Git repository by running: $ git pull https://github.com/yu-iskw/spark minor-remove-spaces

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-11-16 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-157283184 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

2015-11-12 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-156182872 ping @taishi-oss --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-11420 Updating Stddev support via Impera...

2015-11-12 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9380#issuecomment-156181157 @JihongMA thanks for the update! Could you revert `Skewness.scala` and `Kurtosis.scala`. Since I don't think the change relates to the issue. I know this is a minor

[GitHub] spark pull request: [SPARK-10266][Documentation, ML] Fixed @Since ...

2015-11-12 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9338#issuecomment-156187540 @noel-smith could you review it when you have time? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: SPARK-11420 Updating Stddev support via Impera...

2015-11-12 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9380#issuecomment-156177206 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6519][ML] Add spark.ml API for bisectin...

2015-11-10 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/9604 [SPARK-6519][ML] Add spark.ml API for bisecting k-means You can merge this pull request into a Git repository by running: $ git pull https://github.com/yu-iskw/spark SPARK-6519 Alternatively

[GitHub] spark pull request: [SPARK-6519][ML] Add spark.ml API for bisectin...

2015-11-10 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9604#issuecomment-155587648 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6519][ML] Add spark.ml API for bisectin...

2015-11-10 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9604#issuecomment-155587079 @jkbradley @mengxr could you review it when you have time? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-11566][MLlib][Python] Refactoring Gauss...

2015-11-10 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9534#issuecomment-155608020 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11611][MLlib][Python] Python API for bi...

2015-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9583#issuecomment-155271852 @mengxr could you review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11611][MLlib][Python] Python API for bi...

2015-11-09 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/9583 [SPARK-11611][MLlib][Python] Python API for bisecting k-means You can merge this pull request into a Git repository by running: $ git pull https://github.com/yu-iskw/spark SPARK-11611

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-155175314 @jkbradley sure! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6517][mllib] Implement the Algorithm of...

2015-11-09 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/5267#discussion_r44322215 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala --- @@ -0,0 +1,489 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-6517][mllib] Implement the Algorithm of...

2015-11-09 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/5267#discussion_r44321863 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala --- @@ -0,0 +1,489 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-6517][mllib] Implement the Algorithm of...

2015-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/5267#issuecomment-155314648 @jkbradley thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6517][mllib] Implement the Algorithm of...

2015-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/5267#issuecomment-155231942 @freeman-lab thank you for your great support! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-155232384 @jkbradley I send the PR at https://github.com/apache/spark/pull/9577. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-11610][MLlib][Python][Docs] Make the do...

2015-11-09 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/9577 [SPARK-11610][MLlib][Python][Docs] Make the docs of LDAModel.describeTopics in Python more specific cc @jkbradley You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-6517][mllib] Implement the Algorithm of...

2015-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/5267#issuecomment-155226627 Thank you for merging it!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11610][MLlib][Python][Docs] Make the do...

2015-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9577#issuecomment-155244740 Thanks for merging it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10863][SPARKR] Method coltypes() (New v...

2015-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9579#issuecomment-155249581 @olarayej could you please check the style warnings with `./dev/lint-r` on your local computer before pushing commits. Thanks. --- If your project is set up

[GitHub] spark pull request: [SPARK-10280][MLlib][PySpark][Docs] Add @since...

2015-11-08 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8690#issuecomment-154885652 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10280][MLlib][PySpark][Docs] Add @since...

2015-11-08 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8690#issuecomment-154885616 @noel-smith thanks you for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-154585403 @jkbradley @davies could you review it? I modified the type conversion using `SerDe.dumps`. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2015-11-06 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/9535 [SPARK-11515][ML] QuantileDiscretizer should take random seed cc @jkbradley You can merge this pull request into a Git repository by running: $ git pull https://github.com/yu-iskw/spark SPARK

[GitHub] spark pull request: [SPARK-11566][MLlib][Python] Refactoring Gauss...

2015-11-06 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/9534 [SPARK-11566][MLlib][Python] Refactoring GaussianMixtureModel.gaussians in Python cc @jkbradley You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-154629369 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-154643744 Thank you for merging it and your great support! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-154618704 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-154617157 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-154640689 @davies thanks for the review. I fixed them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8563#issuecomment-154501697 @nilmeier thanks. This document would help you with contributing to Spark. https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide --- If your

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-154508219 I think it would be natural to fix the Scala error message and fix the condition in Python. The algorithm checks not the indexes have duplicated values, but the indexes

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8643#discussion_r44164309 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/LDAModelWrapper.scala --- @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8643#discussion_r44168908 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/LDAModelWrapper.scala --- @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8643#discussion_r44171965 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/LDAModelWrapper.scala --- @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8643#discussion_r44185186 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/LDAModelWrapper.scala --- @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-154512438 @urvishparikh oh, got it. Thank you for letting me know. It's my fault. If the indexes are already sorted, the condition should be `==`, right? --- If your project

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-154518546 All right. We should focus on change the error message in this issue. Thank you for making it clear. LGTM --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-154532750 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-154537228 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-11420 Updating Stddev support via Impera...

2015-11-05 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9380#issuecomment-154164156 @JihongMA I don't know if there are any strong reasons in terms of catalyst. However, personally I think we should separate changing the return type and `null` from

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

2015-11-05 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r44093654 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala --- @@ -165,8 +185,9 @@ object GBTClassifier { * @param

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

2015-11-05 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r44093668 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -390,8 +404,9 @@ class LogisticRegression(override val uid

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

2015-11-05 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r44093643 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -103,11 +116,12 @@ object DecisionTreeClassifier

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

2015-11-05 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r44093665 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -390,8 +404,9 @@ class LogisticRegression(override val uid

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

2015-11-05 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r44093682 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala --- @@ -110,8 +116,9 @@ class NaiveBayes(override val uid: String

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

2015-11-05 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r44093689 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -71,16 +71,19 @@ private[ml] trait OneVsRestParams extends

  1   2   3   4   5   6   >