[GitHub] spark issue #18351: [SPARK-21135][WEB UI] On history server pageļ¼Œduration ...

2017-06-19 Thread zhuoliu
Github user zhuoliu commented on the issue: https://github.com/apache/spark/pull/18351 @fjh100456 this change looks good to me. Could you please add a screenshot for your test? Regarding your question of " the application of an exception abort (such as the applic

[GitHub] spark issue #13670: [SPARK-15951] Change Executors Page to use datatables to...

2016-06-16 Thread zhuoliu
Github user zhuoliu commented on the issue: https://github.com/apache/spark/pull/13670 Generally looks great to me, I am good with it as long as @tgravescs verifies. One minor concern is that we may move the utility functions from executorspage.js and historypage.ps to a common

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-05-09 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217971974 sure, thanks @srowen! Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-05-09 Thread zhuoliu
Github user zhuoliu closed the pull request at: https://github.com/apache/spark/pull/12075 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-03-30 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/spark/pull/12075 [SPARK-13064] Make sure attemptId not none for Rest API ## What changes were proposed in this pull request? For some application that does not set attemptId for their attempts, e.g., spark

[GitHub] spark pull request: [SPARK-14049] [CORE] Add functionality in spar...

2016-03-24 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/11867#issuecomment-201047774 I am +1 to your change. @tgravescs @rxin , could any of you verify this patch? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14049] [CORE] Add functionality in spar...

2016-03-22 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/11867#issuecomment-199888492 Hi @paragpc , since this is related to UI, could you upload some screenshots for your changes? Thanks. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-13775] History page sorted by completed...

2016-03-09 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/spark/pull/11608 [SPARK-13775] History page sorted by completed time desc by default. ## What changes were proposed in this pull request? Originally the page is sorted by AppID by default. After tests

[GitHub] spark pull request: [SPARK-13481] Desc order of appID by default f...

2016-02-26 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/11357#issuecomment-189516371 This basically provides a default view of sorting when the page is loaded. User can easily sort by start time or other columns by clicking the column name

[GitHub] spark pull request: [SPARK-13481] Desc order of appID by default f...

2016-02-24 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/spark/pull/11357 [SPARK-13481] Desc order of appID by default for history server page. ## What changes were proposed in this pull request? Now by default, it shows as ascending order of appId. We might

[GitHub] spark pull request: [SPARK-11316] setupGroups in coalescedRDD caus...

2016-02-24 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/11060#issuecomment-188343621 @tgravescs Now Closing this one since we have another pull request up for this issue in: https://github.com/apache/spark/pull/11327 --- If your project is set up

[GitHub] spark pull request: [SPARK-11316] setupGroups in coalescedRDD caus...

2016-02-24 Thread zhuoliu
Github user zhuoliu closed the pull request at: https://github.com/apache/spark/pull/11060 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-13364] Sort appId as num rather than st...

2016-02-22 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/11259#issuecomment-187487562 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13364] Sort appId as num rather than st...

2016-02-19 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/11259#issuecomment-186360098 Hi @rxin , yes, I see the pull request template and now updated the description. @tgravescs , I addressed your comment. Not find a javascript function I can

[GitHub] spark pull request: [SPARK-13364] Sort appId as num rather than st...

2016-02-18 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/spark/pull/11259 [SPARK-13364] Sort appId as num rather than str in history page. ## What changes were proposed in this pull request? History page now sorts the appID as a string, which can lead to unexpected

[GitHub] spark pull request: [SPARK-11316] setupGroups in coalescedRDD caus...

2016-02-03 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/spark/pull/11060 [SPARK-11316] setupGroups in coalescedRDD causes super long delay. In coalescedRDD, the setupGroups causes super long delay due to the O(n^2) loop in the second while. That while is used to make

[GitHub] spark pull request: [SPARK-11316] setupGroups in coalescedRDD caus...

2016-02-03 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/11060#issuecomment-179589375 @alig Hi Ali, would you mind having a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13126] fix the right margin of history ...

2016-02-02 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/spark/pull/11029 [SPARK-13126] fix the right margin of history page. The right margin of the history page is little bit off. A simple fix for that issue. You can merge this pull request into a Git repository

[GitHub] spark pull request: [SPARK-13126] fix the right margin of history ...

2016-02-02 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/11029#issuecomment-178816316 ![history-margin](https://cloud.githubusercontent.com/assets/11683054/12764141/b62f88a0-c9bd-11e5-9cbf-260b94b8ec3c.png) Sure. --- If your project is set up

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

2016-02-02 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/11038#issuecomment-178984171 Tested also for history page. Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13126] fix the right margin of history ...

2016-02-02 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/11029#issuecomment-178983626 Hi @ajbozarth , the screenshot you pasted is a little different from mine since your date and app-Id are wrapped into two lines while there is still lots of space

[GitHub] spark pull request: [SPARK-10873] Support column sort and search f...

2016-01-28 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/10648#issuecomment-176303757 JIRA file here: https://issues.apache.org/jira/browse/SPARK-13064 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-10873] Support column sort and search f...

2016-01-27 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/10648#issuecomment-175966503 Hi @tgravescs , finally fixed the paging stuff in RowsGrouping. :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2016-01-26 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/9946#issuecomment-175121155 Sure. A brief summary is that: (picked a few conclusive points from above): "At the point we call System.exit here all user code is done a

[GitHub] spark pull request: [SPARK-10873] Support column sort and search f...

2016-01-26 Thread zhuoliu
Github user zhuoliu commented on a diff in the pull request: https://github.com/apache/spark/pull/10648#discussion_r50931113 --- Diff: core/src/main/resources/org/apache/spark/ui/static/jquery.cookies.2.2.0.min.js --- @@ -0,0 +1,18 @@ +/** + * Copyright (c) 2005 - 2010

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2016-01-21 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/9946#issuecomment-173706813 Hi @vanzin , do we want to amend the commit message to something like this? "Call system.exit explicitly to make sure non-daemon user threads terminate. Wi

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2016-01-21 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/9946#issuecomment-173732459 Thanks @vanzin , commit message updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2016-01-21 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/9946#issuecomment-173737073 Sorry for that. Just updated the first comment and changed the commit message back to original. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2016-01-21 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/9946#issuecomment-173686628 Now reopen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2016-01-21 Thread zhuoliu
GitHub user zhuoliu reopened a pull request: https://github.com/apache/spark/pull/9946 [SPARK-10911] Executors should System.exit on clean shutdown. https://issues.apache.org/jira/browse/SPARK-10911 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2016-01-20 Thread zhuoliu
Github user zhuoliu closed the pull request at: https://github.com/apache/spark/pull/9946 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2016-01-20 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/9946#issuecomment-173274389 Thanks, closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2016-01-20 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/9946#issuecomment-173268512 @vanzin @srowen @andrewor14 , I think your concerns make sense. Also, adding timeout might have another issue that resources cannot be released immediately even

[GitHub] spark pull request: [SPARK-10873] Support column sort and search f...

2016-01-07 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/10648#issuecomment-169811351 Hi @vanzin , I added two new fields (duration Long, lastUpdated Date) into ApplicationAttemptInfo in api.scala. The jenkins compile is complaining about mima binary

[GitHub] spark pull request: [SPARK-10873] Support column sort and search f...

2016-01-07 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/10648#issuecomment-169825389 Hi @vanzin , thanks for the info. BTW, I have fixed the issue you mentioned about messed zebra striping. Now the zebra striping is exactly as what we have

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2015-11-24 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/spark/pull/9946 [SPARK-10911] Executors should System.exit on clean shutdown. https://issues.apache.org/jira/browse/SPARK-10911 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-4223] [Core] Support * in acls.

2015-08-27 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/8398#issuecomment-135452755 Sure. Docs updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4223] [Core] Support * in acls.

2015-08-26 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/8398#issuecomment-135194775 Thanks @vanzin, comments addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-4223] [Core] Support * in acls.

2015-08-25 Thread zhuoliu
Github user zhuoliu commented on a diff in the pull request: https://github.com/apache/spark/pull/8398#discussion_r37881755 --- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala --- @@ -125,6 +125,27 @@ class SecurityManagerSuite extends SparkFunSuite

[GitHub] spark pull request: Spark-4223 Support * in acls.

2015-08-24 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/spark/pull/8398 Spark-4223 Support * in acls. SPARK-4223. Currently we support setting view and modify acls but you have to specify a list of users. It would be nice to support * meaning all