AngersZhuuuu commented on a change in pull request #25028: [SPARK-28227][SQL]
Support TRANSFORM with aggregation.
URL: https://github.com/apache/spark/pull/25028#discussion_r339891398
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -506,12 +511,71 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
AttributeReference("value", StringType)()), true)
}
+ val namedExpressions = expressions.map {
+ case e: NamedExpression => e
+ case e: Expression => UnresolvedAlias(e)
+ }
Review comment:
It is ok even to rename all expression with `aliasFunc` in this place.
After current busy job I will restart this pr and follow your nice
suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
