[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r609329246 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1788,16 +1788,30 @@ class Analyzer(override

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608371608 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1787,16 +1787,36 @@ class Analyzer(override

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608352704 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -598,8 +598,8 @@ class Analyzer(override val

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608352609 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1787,16 +1787,41 @@ class Analyzer(override

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608352564 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1787,16 +1787,41 @@ class Analyzer(override

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r608352335 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -144,12 +147,12 @@ case class

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605634358 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1950,16 +1951,39 @@ class Analyzer(override

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605518637 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1950,16 +1950,39 @@ class Analyzer(override

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605486875 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1950,16 +1950,39 @@ class Analyzer(override

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r605484868 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1950,16 +1950,39 @@ class Analyzer(override

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r604908038 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/SubstituteUnresolvedOrdinals.scala ## @@ -27,13 +27,23 @@ import

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r514793291 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -244,6 +244,7 @@ class Analyzer(

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r514780876 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-by-ordinal.sql ## @@ -54,6 +54,26 @@ select count(a), a from (select 1 as a) tmp

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r514734648 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -244,6 +244,7 @@ class Analyzer(

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r514707063 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3691,6 +3691,22 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r514706231 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -244,6 +244,7 @@ class Analyzer(

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r511957287 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3691,6 +3691,22 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r511955190 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1775,17 +1776,29 @@ class Analyzer(

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AngersZh commented on a change in pull request #30145: URL: https://github.com/apache/spark/pull/30145#discussion_r511932497 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -244,6 +244,7 @@ class Analyzer(