[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-12-01 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-736989381 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-30 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-736156071 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-30 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-735883750 PR desc updated and add more UT This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-29 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-735399362 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-24 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-732948270 Any update? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-20 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-731198109 > Just out of curiosity ‒ cannot the proposed use case be addressed with > > ``` > array_intersect(right, left) = right > ``` > > ? Computational e

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-20 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-731195432 > Could you please add more complex test cases using `ArrayType(BinaryType)` in addition to `ArrayType(IntegerType)`? > > And, could you please add test cases regardi

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-17 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-729446492 > When I only read the first description, the behavior is unknown regarding what `contains_array` mean like the following cases > > * `array_contains_array(array(1, 2

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-17 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-729400441 > @AngersZh, do you know if other DBMSes support this expressions? PostgresSQL support `@>` and `<@` https://www.postgresql.org/docs/12/functions-array.html

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-17 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-729330960 gentle ping @maropu @cloud-fan @HyukjinKwon This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-05 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-722892310 > Probably, `arrays_contains(array(1, 2, 3), 2) AND arrays_contains(array(1, 2, 3), 3) `? First, if `arrays_contains_array(array(1, 2, 3, ), array(1, 2, 3, 4,

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-05 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-722875681 > arrays_overlap(array(1, 2, 3), array(2, 3))? ArrayOverlap checks if the two arrays contain at least one common element. > Anyway, I think you need to describ

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-05 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-722827762 > > ``` > > > SELECT _FUNC_(array(1, 2, 3), array(2)); > > ``` > > Why we need this func (e.g.,. other systems support this func)? Seems like the example abol

[GitHub] [spark] AngersZhuuuu commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-04 Thread GitBox
AngersZh commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721741351 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple