AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-800012610
> If we never overflow, why do we need to return unsigned results?
Hmmm you mean negative number? `conv(number, fromBase, toBase)`. This pr
won't change behavior when
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-799988616
> I've reverted this commit.
>
> Regarding `conv_without_overflow`, are we going to disallow negative
`toBase`? Does any other database have it?
Hmmm why do we
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-799921923
Yea, check the detail of mysql
https://www.w3resource.com/mysql/mathematical-functions/mysql-conv-function.php
I means if to base is positive, we treat it as unsigned. th
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-799894002
> I found a behavior change here.
>
> Before this commit
>
> ```
> scala> sql("select conv(-100, 10, 10)").show(20, false)
> +
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744365193
> value(i) = (tmpV - q * radix).byteValue()
Thanks for mention this point
This is an automated messa
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744167296
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-744117862
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-741674093
ping @cloud-fan @srowen Any more update?
This is an automated message from the Apache Git Service.
To respo
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-738525538
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737772632
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737699065
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-737690572
> Fixing overflow should be good. It's not very intuitive to read the
results of this function. Is there any database we can use as a reference?
Mysql:
https://dev.m
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735887274
> It's a behavior change which could be OK if it's a bug fix. Do SQL
standards have anything to say about what the result should be?
Didn't find the place to describ
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-735399107
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731996617
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-731958026
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-729331125
gentle ping @dongjoon-hyun @HyukjinKwon @cloud-fan
This is an automated message from the Apache Git Servic
AngersZh commented on pull request #30350:
URL: https://github.com/apache/spark/pull/30350#issuecomment-726638310
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
18 matches
Mail list logo
