[GitHub] [spark] AngersZhuuuu commented on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
AngersZh commented on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830736256 > Please, address comments. Sorry for my late, since yesterday's run failed so I revert and recheck, but some thing urgent break my work. -- This is an automated m

[GitHub] [spark] AngersZhuuuu commented on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-04-30 Thread GitBox
AngersZh commented on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830505502 @MaxGekk I think it's ready for review now, but I am confused how can I use `dayTimePattern(DAY -> SECOND)` in match case ? When I write ``` val regex = da

[GitHub] [spark] AngersZhuuuu commented on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-04-30 Thread GitBox
AngersZh commented on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830489790 @MaxGekk Can be reviewed now, but currently this method does not seem to be very efficient,Maybe should I add a new method to calculate calculate total microseconds separ

[GitHub] [spark] AngersZhuuuu commented on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-04-29 Thread GitBox
AngersZh commented on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-829010078 @MaxGekk I meet a case IntervalUtils.fromDayTimeString("2:03:04") throw exception ``` [info] Cause: java.lang.IllegalArgumentException: requirement failed: I