[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2022-05-31 Thread GitBox
AngersZh commented on PR #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-1143043489 @gongzh021 Maybe you can check this commit https://github.com/apache/spark/pull/33457/commits/dba26cd5bd1aaacb01e08cfcfef9f02ffe96d018 -- This is an automated message from the Apac

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2022-05-31 Thread GitBox
AngersZh commented on PR #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-1142188571 @gongzh021 Maybe you can check this commit https://github.com/apache/spark/pull/33457/commits/dba26cd5bd1aaacb01e08cfcfef9f02ffe96d018 -- This is an automated message from the Apac

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-08-02 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-890805684 ping @gengliangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-29 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-889575948 @gengliangwang GA passed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-29 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-889333209 > @AngersZh seriously, the description is badly written. > > ``` > When we use prometheus to fetch metrics, always pull data before application started. >

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-28 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-888363378 > @AngersZh Please update the PR description. Especially for the first and third ones. How about current? -- This is an automated message from the Apache Git S

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-888053288 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-888050626 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-888032835 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-887958703 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-887666835 > UISeleniumSuite How about current UT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-887639943 > @AngersZh The new approach looks good. Shall we add test cases for it? If there is way to start a SparkUI separately I think I can write a UT...but not found ye

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-88747 > @AngersZh This change works with Chrome but with Firefox as expected. Could you set content type? Updated, how about current? ![image](https://user-images.

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-887452045 > [#33457 (comment)](https://github.com/apache/spark/pull/33457#issuecomment-887328231) > > The web UI looks good. How about REST request? All return same UI.

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-887397326 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-887328461 > > With this 500 and error stack in the log makes user confused too.. they always ask me if there is something wong. > > At least before the changes it shows hint "i

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-27 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-887328231 > Shall we make the RESTFUL request hang and the web page loading if the spark application is not fully started? Show as below is ok? ![image](https://user-images

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-26 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-886436290 Also you can check this related issue https://github.com/apache/spark/pull/1966 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-25 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-886422921 > It might be confusable for users. With this 500 and error stack in the log makes user confused too.. they always ask me if there is something wong. Always user w

[GitHub] [spark] AngersZhuuuu commented on pull request #33457: [SPARK-36237][UI][SQL] Attach and start handler after application started in UI

2021-07-24 Thread GitBox
AngersZh commented on pull request #33457: URL: https://github.com/apache/spark/pull/33457#issuecomment-886136670 Any suggestion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific