DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-532013299
@maropu Yes, I'm following everything. Yes, I can split th PR.
This is an
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-527446538
@gatorsmile @maropu Sorry guys, altough I`ve got noticed about some of your
comments, I didn't get any notification about the new
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-519127951
@maropu Thank you for the revision, it was very clarifying. I also think
that I didn't paid enough attention to which differences are
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-518678362
@dongjoon-hyun I applied the suggestions by @maropu , what do you think?
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-515050128
You're welcome. Also, you are doing a majestic reviewer job.
I commented out the calls to `explain`. If you find more things that can
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-514703690
Ok, thank you for the explanation. I found that code snippet in a .sql file,
that's why I thought that it was related to SQL Language
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-514606530
I don't know, I didn't find anywhere a list of which features Spark has
support to. And `FILTER` works at some point:
```
select
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-514268697
@dongjoon-hyun I've been trying to make filtering works for a while but
without success. For instance, in the following snippet
```
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-512472968
@dongjoon-hyun Nice. So I'll document them for now.
This is an automated
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-512363836
Nice! So, I'm almost finishing it, I get stucked in the following questions,
because I'm not sure if the current behavior is intended or if
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-512357993
@dongjoon-hyun Thank you for the suggestion! I review'd it and I only missed
a `drop view` at the end.
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-511884689
@dongjoon-hyun Sorry for taking too long on this one. I'll update the tests
with the new JIRAs/comments and finish it until tomorrow.
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-508753656
@dongjoon-hyun You are absolutely right - for some reason, results from two
queries were not truncated. I commented them out and will
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-507660115
By the way, the CI looks fine now.
This is an automated message from the
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-504001147
You are right, I had an environment variable that was setting ipython
instead. Whatever, I regenerated the golden files, looks fine now.
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-502838383
I updated with a few changes. I just got noticed (after @wangyum help) that
I was having problems in `udf-inner-join.sql`, but I didn't
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-502659861
Hmm I was always generating them, I think that at the end I made a minor
change and forgot to rerun then because I just changed a comment.
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-502489492
Btw, another question: the CI isn't passing and I can't identify the query:
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql
URL: https://github.com/apache/spark/pull/24881#issuecomment-502456144
Hey guys, I added new references to JIRAs. I removed the WIP tag so that the
CI could run because I wanted to be sure that I wasn't
19 matches
Mail list logo
