[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2023-03-05 Thread via GitHub
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1455620898 Yes, it looks like it removes the **empty** table location after **overwriting** the table failed due to the `ArithmeticException`. @cloud-fan do you consider the removal of an emp

[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2023-01-05 Thread GitBox
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1373297981 I'll give it a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2023-01-05 Thread GitBox
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1372759273 Unfortunately, a similar issue exists for Spark 3.4.0 as well, created issue SPARK-41914 to track that. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2022-11-09 Thread GitBox
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1308492632 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2022-11-08 Thread GitBox
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1307611139 All done, all green: https://github.com/G-Research/spark/actions/runs/3420780216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2022-11-08 Thread GitBox
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1306782288 There is no Spark 3.x release that does not suffer from this. This blocks people from moving to Spark 3, while Spark 3.0 and 3.1 are already EOL. Please reconsider providing a fix before

[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2022-11-03 Thread GitBox
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1302512656 @ming95 Your query is affected by this issue as well (Spark 3.3): ``` Sort [input[2, string, true] ASC NULLS FIRST], false, 0 +- Project [id#37, sort_col#38, empty2null(p#

[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2022-10-31 Thread GitBox
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1296765612 @HyukjinKwon never mind, I have looked at the wrong workflow ("Build") but branch 3.3 has the old workflows ("Build and test"). -- This is an automated message from the Apache Git Serv

[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2022-10-31 Thread GitBox
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1296712835 @HyukjinKwon this PR targets `branch-3.3`, not `master`. How are tests kicked off in my fork? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2022-10-31 Thread GitBox
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1296701255 @cloud-fan @sunchao is there a chance to get this regression fix into 3.2 before the upcoming 3.2.3 release? There is currently no Spark 3 release that does not suffer from this r

[GitHub] [spark] EnricoMi commented on pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

2022-10-23 Thread GitBox
EnricoMi commented on PR #38358: URL: https://github.com/apache/spark/pull/38358#issuecomment-1288156851 @cloud-fan this fixes a very peculiar bug introduced via AQE in Spark 3.0. With Spark 3.4, the issue disappeared. A user-defined ordering, that starts with the partition columns, i