[GitHub] [spark] EnricoMi commented on pull request #39752: [SPARK-42168][SQL][PYTHON][FOLLOW-UP] Test FlatMapCoGroupsInPandas with Window function

2023-01-30 Thread via GitHub
EnricoMi commented on PR #39752: URL: https://github.com/apache/spark/pull/39752#issuecomment-1408400097 @HyukjinKwon understood: #39803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [spark] EnricoMi commented on pull request #39752: [SPARK-42168][SQL][PYTHON][FOLLOW-UP] Test FlatMapCoGroupsInPandas with Window function

2023-01-30 Thread via GitHub
EnricoMi commented on PR #39752: URL: https://github.com/apache/spark/pull/39752#issuecomment-1408295707 @sunchao @HyukjinKwon can you merge this into branch-3.4 as well, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] EnricoMi commented on pull request #39752: [SPARK-42168][SQL][PYTHON][FOLLOW-UP] Test FlatMapCoGroupsInPandas with Window function

2023-01-28 Thread via GitHub
EnricoMi commented on PR #39752: URL: https://github.com/apache/spark/pull/39752#issuecomment-1407371504 Commit d9ca9820 can be merged from master into branch-3.4 without conflicts. Do you need a PR from me for this? Merging this into branch-3.3 requires resolving conflicts, done in #

[GitHub] [spark] EnricoMi commented on pull request #39752: [SPARK-42168][SQL][PYTHON][FOLLOW-UP] Test FlatMapCoGroupsInPandas with Window function

2023-01-27 Thread via GitHub
EnricoMi commented on PR #39752: URL: https://github.com/apache/spark/pull/39752#issuecomment-1407068685 I'd appreciate if this test coverage would also make it into 3.4 and 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] EnricoMi commented on pull request #39752: [SPARK-42168][SQL][PYTHON][FOLLOW-UP] Test FlatMapCoGroupsInPandas with Window function

2023-01-26 Thread via GitHub
EnricoMi commented on PR #39752: URL: https://github.com/apache/spark/pull/39752#issuecomment-1406094390 Done, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] EnricoMi commented on pull request #39752: [SPARK-42168][SQL][PYTHON][FOLLOW-UP] Test FlatMapCoGroupsInPandas with Window function

2023-01-25 Thread via GitHub
EnricoMi commented on PR #39752: URL: https://github.com/apache/spark/pull/39752#issuecomment-1404638163 @sunchao @HyukjinKwon can we port the tests from #39717 to master, and back port them to branch-3.4 and branch-3.3? -- This is an automated message from the Apache Git Service. To resp