[GitHub] [spark] HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter

2019-08-11 Thread GitBox
HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter URL: https://github.com/apache/spark/pull/25407#issuecomment-520263670 > Yes, sounds like the docs need an update. Is there any place in the user docs that this kind of gotcha s

[GitHub] [spark] HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter

2019-08-11 Thread GitBox
HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter URL: https://github.com/apache/spark/pull/25407#issuecomment-520264633 I guess it's not only applied to Spark 3.0 but applied to all the versions. (may worth to port back) End u

[GitHub] [spark] HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter

2019-08-13 Thread GitBox
HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter URL: https://github.com/apache/spark/pull/25407#issuecomment-520737809 I guess I addressed all review comments. Could we please take another round of reviews? -

[GitHub] [spark] HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter

2019-08-15 Thread GitBox
HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter URL: https://github.com/apache/spark/pull/25407#issuecomment-521898420 @zsxwing kindly reminder. This is an auto

[GitHub] [spark] HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter

2019-08-20 Thread GitBox
HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter URL: https://github.com/apache/spark/pull/25407#issuecomment-522919791 Thanks for the quick review and merge! Th