[GitHub] [spark] HeartSaVioR commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-19 Thread GitBox
HeartSaVioR commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-533411970 Just to determine the next action, would we want to include newer discussion (@viirya

[GitHub] [spark] HeartSaVioR commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
HeartSaVioR commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532910882 And another possible improvement on the randomized test in ObjectHashAggregateSuite...

[GitHub] [spark] HeartSaVioR commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
HeartSaVioR commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532910140 Btw, submitted a patch #25835 for following up my own comment: https://github.com/apac

[GitHub] [spark] HeartSaVioR commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-18 Thread GitBox
HeartSaVioR commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-532862764 Updated, please take a next round of review. Thanks! -