[GitHub] [spark] HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly

2020-01-09 Thread GitBox
HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly URL: https://github.com/apache/spark/pull/26845#issuecomment-572441476 Thanks for the suggestion! Submitted #27146 to address documentation. Actually the producer pool is ver

[GitHub] [spark] HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly

2019-12-23 Thread GitBox
HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly URL: https://github.com/apache/spark/pull/26845#issuecomment-568602465 Thanks for reviewing and merging! This

[GitHub] [spark] HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly

2019-12-11 Thread GitBox
HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly URL: https://github.com/apache/spark/pull/26845#issuecomment-564427281 retest this, please This is an automat

[GitHub] [spark] HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly

2019-12-10 Thread GitBox
HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly URL: https://github.com/apache/spark/pull/26845#issuecomment-564407397 Ah yes I had been investigating the issue. Thanks for reminding! Will update soon. ---

[GitHub] [spark] HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly

2019-12-10 Thread GitBox
HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly URL: https://github.com/apache/spark/pull/26845#issuecomment-564382948 Similarly I feel it would be ideal to move the files regarding consumer pool to `consumer` package, and

[GitHub] [spark] HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly

2019-12-10 Thread GitBox
HeartSaVioR commented on issue #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly URL: https://github.com/apache/spark/pull/26845#issuecomment-564378827 cc. @zsxwing @vanzin @gaborgsomogyi (Gabor may not be available in this month but cc. to let him catch