[GitHub] [spark] HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach

2020-03-05 Thread GitBox
HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach URL: https://github.com/apache/spark/pull/27765#issuecomment-595597068 @gengliangwang Thanks for noticing! I've raised #27825 for

[GitHub] [spark] HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach

2020-03-04 Thread GitBox
HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach URL: https://github.com/apache/spark/pull/27765#issuecomment-594963666 @gengliangwang I'll raise a PR for 3.0. I can't cherry-pick

[GitHub] [spark] HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach

2020-03-04 Thread GitBox
HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach URL: https://github.com/apache/spark/pull/27765#issuecomment-594480092 retest this, please

[GitHub] [spark] HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach

2020-03-03 Thread GitBox
HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach URL: https://github.com/apache/spark/pull/27765#issuecomment-594217162 @gengliangwang Thanks! Just rebased. Please take a look.

[GitHub] [spark] HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach

2020-03-02 Thread GitBox
HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach URL: https://github.com/apache/spark/pull/27765#issuecomment-593799451 FYI I'd like to see #27763 be merged, and happy to rebase if

[GitHub] [spark] HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach

2020-03-02 Thread GitBox
HeartSaVioR commented on issue #27765: [SPARK-31014][CORE] InMemoryStore: remove key from parentToChildrenMap when removing key from CountingRemoveIfForEach URL: https://github.com/apache/spark/pull/27765#issuecomment-593799144 cc. @gengliangwang @cloud-fan