[GitHub] [spark] HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-04-01 Thread GitBox
HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-607538903 I tend to agree it would be ideal to get this patch in Spark 3.0.0, but then this patch will become a blocker for Spark 3.0.0,

[GitHub] [spark] HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-04-01 Thread GitBox
HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-607532712 I agree turning on the legacy config is just a workaround which I will never recommend end users to turn off. I expect I would

[GitHub] [spark] HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-03-31 Thread GitBox
HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-607032955 Maybe we also need to change two "create table" pages and migration guide page as well regardless of the approach, since we are

[GitHub] [spark] HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-03-31 Thread GitBox
HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-607003471 > The create test in SparkSqlParserSuite highlighted an existing problem with spark.sql.legacy.createHiveTableByDefault.enabled.

[GitHub] [spark] HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-03-30 Thread GitBox
HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-606310697 Thanks for the detailed answer. Really appreciated. I misunderstood something as you commented, but it seems to come from

[GitHub] [spark] HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-03-28 Thread GitBox
HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-605538309 Same here, please describe TODO list for this PR to remove WIP. If I skimmed the code correctly, this "requires" end users

[GitHub] [spark] HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-03-26 Thread GitBox
HeartSaVioR commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-604808159 I don't know who marked comments as resolved so please correct me if I'm wrong, but assuming that @cloud-fan comments to the