[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-08 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-65577 OK confirmed the hotfix works in master and branch-2.4 as well. Will submit a hotfix soon. This is an

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-08 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655752902 I'll submit a hotfix patch against master (can cherry-pick to broken branches) once I confirmed my fix works for branch-2.4 as well (it should work with master as well, as

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-08 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655745634 Probably better to land the hotfix into master as well if we go with hotfix, as it looks to be safer assumption rather than depending on 245aee9.

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-08 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655744956 Thanks for sharing the test failure, @dongjoon-hyun . I took a quick look, and realized 245aee9fc85c22352bb946a8987229270ba6069f was landed only on master branch (as it's

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-08 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655530835 Oh OK. Thanks for noticing. I hope we'd be a bit flexible and pragmatic, but I also sincerely respect the rule and policy. I'll follow it in next time.

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-08 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655504143 Thanks @zhli1142015 for the contribution! Merged into master, branch-3.0, branch-2.4 respectively. This is

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-08 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655490854 > build 125313 org.apache.spark.sql.hive.thriftserver.HiveSessionImplSuite.(It is not a test it is a sbt.testing.SuiteSelector)

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-08 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655327071 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-08 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655327021 Let me trigger the test once more. If that also fails with flaky test we'd probably be better to just merge.

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-08 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655325185 The PR builders look to be quite unstable, though all the test failures are not related to the change. > build 125054

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655191991 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655088482 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-06 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-654583873 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-06 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-654439910 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-06 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-654200570 ``` org.apache.spark.sql.hive.thriftserver.HiveSessionImplSuite.(It is not a test it is a sbt.testing.SuiteSelector) Error Details

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-06 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-654200677 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-06 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-654091513 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-05 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-653946129 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-02 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-653258728 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-02 Thread GitBox
HeartSaVioR commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-652959861 retest this, please This is an automated message from the Apache Git Service. To respond to the message,