[GitHub] [spark] HeartSaVioR commented on pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-11 Thread GitBox
HeartSaVioR commented on pull request #28967: URL: https://github.com/apache/spark/pull/28967#issuecomment-657066699 Thanks! Merged into master. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] HeartSaVioR commented on pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-11 Thread GitBox
HeartSaVioR commented on pull request #28967: URL: https://github.com/apache/spark/pull/28967#issuecomment-657021428 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-10 Thread GitBox
HeartSaVioR commented on pull request #28967: URL: https://github.com/apache/spark/pull/28967#issuecomment-656928960 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-10 Thread GitBox
HeartSaVioR commented on pull request #28967: URL: https://github.com/apache/spark/pull/28967#issuecomment-656558557 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-09 Thread GitBox
HeartSaVioR commented on pull request #28967: URL: https://github.com/apache/spark/pull/28967#issuecomment-656475406 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-06 Thread GitBox
HeartSaVioR commented on pull request #28967: URL: https://github.com/apache/spark/pull/28967#issuecomment-654586287 cc. @srowen as the replaced code here was reviewed by him This is an automated message from the Apache Git

[GitHub] [spark] HeartSaVioR commented on pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-06 Thread GitBox
HeartSaVioR commented on pull request #28967: URL: https://github.com/apache/spark/pull/28967#issuecomment-65447 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HeartSaVioR commented on pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-06 Thread GitBox
HeartSaVioR commented on pull request #28967: URL: https://github.com/apache/spark/pull/28967#issuecomment-654065873 Thanks for the links. That's the all what I'd like to see. > This is a redundant code of the package-private JDK counterpart. As the code not a perfect match even it

[GitHub] [spark] HeartSaVioR commented on pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-05 Thread GitBox
HeartSaVioR commented on pull request #28967: URL: https://github.com/apache/spark/pull/28967#issuecomment-653973297 I wonder we can link the spot on the JDK code (if it was from OpenJDK) so that we feel confident to remove the relevant test. I usually see the concern of removing