[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-10-11 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-706912198 You're right. Would you like to go with revert & another PR, or it's just for information? This is an autom

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-10-09 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-705352048 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-10-08 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-705377157 retest this, please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-10-07 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-705352048 Thanks for reviewing. Addressed review comments. Please take a look again. This is an automated message from

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-10-06 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-704267920 The build failure doesn't look to occur from my change, though that looks to be warn but considered as error and build finally failed. ``` [error] [warn] /home/jen

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-23 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-697178139 Shall we continue review this (prior to #29830) so that the change can be used on the tests for #29756 ? Thanks in advance.

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-21 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-695906232 Shall we have another round of review? Thanks in advance! This is an automated message from the Apache Git S

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-20 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-695906232 Shall we have another round of review? Thanks in advance! This is an automated message from the Apache Git S

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-693700523 cc. @cloud-fan @tdas @zsxwing @gaborgsomogyi @xuanyuanking This is an automated message from the Apache Git

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-693369939 retest this, please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-693225169 retest this, please This is an automated message from the Apache Git Service. To respond to the message, ple