HeartSaVioR commented on pull request #30336:
URL: https://github.com/apache/spark/pull/30336#issuecomment-733274719
Thanks all for reviewing and thanks @gaborgsomogyi for the contribution.
Merged to master.
This is an autom
HeartSaVioR commented on pull request #30336:
URL: https://github.com/apache/spark/pull/30336#issuecomment-733274006
I'll merge this as Github Action passed for the last change (e2f1594).
Jenkins seems to have been unstable and I don't like to drag it anymore due to
this.
---
HeartSaVioR commented on pull request #30336:
URL: https://github.com/apache/spark/pull/30336#issuecomment-731489059
@gaborgsomogyi Could you please fix the merge conflict?
@xuanyuanking
This PR reverted the API change which would address your review comment.
Could you please ver
HeartSaVioR commented on pull request #30336:
URL: https://github.com/apache/spark/pull/30336#issuecomment-729952216
Hmm... Weird. This passes in my local.
```
build/sbt -Phive -Phive-thriftserver "testOnly
org.apache.spark.sql.streaming.ui.StreamingQueryPageSuite"
```
I
HeartSaVioR commented on pull request #30336:
URL: https://github.com/apache/spark/pull/30336#issuecomment-729946621
No worries, I'll make sure I retrigger the build again before merging, and
if it fails I won't merge and ask about fixing the failure.
-
HeartSaVioR commented on pull request #30336:
URL: https://github.com/apache/spark/pull/30336#issuecomment-729650978
791011c looks to address current review comments so far, but would like to
get confirmed by @sarutak and @xuanyuanking .
---
HeartSaVioR commented on pull request #30336:
URL: https://github.com/apache/spark/pull/30336#issuecomment-729351175
If you meant about the "way" to get the list of custom metrics, sure it'd be
ideal to document it. Directly listing the available custom metrics isn't
feasible, and even req
HeartSaVioR commented on pull request #30336:
URL: https://github.com/apache/spark/pull/30336#issuecomment-729345153
> I think it's better to document about
spark.sql.streaming.ui.enabledCustomMetricList and the current available custom
metrics in this PR or a followup PR.
I'm not s
HeartSaVioR commented on pull request #30336:
URL: https://github.com/apache/spark/pull/30336#issuecomment-728660542
@xuanyuanking @sarutak
Appreciate your next round of reviews. Thanks in advance.
This is an automated me
