HeartSaVioR commented on pull request #31937:
URL: https://github.com/apache/spark/pull/31937#issuecomment-812931719
UPDATE: I've added test suite for state store manager PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HeartSaVioR commented on pull request #31937:
URL: https://github.com/apache/spark/pull/31937#issuecomment-809904742
UPDATE: I've added test suite for MergingSessionIterator and updated the
relevant PR.
--
This is an automated message from the Apache Git Service.
To respond to the
HeartSaVioR commented on pull request #31937:
URL: https://github.com/apache/spark/pull/31937#issuecomment-809062076
I filed 5 JIRA issues for all parts, and submitted 3 PRs which are not
dependent to others. Remaining 2 parts depend on others and I'll deal with them
once we merge
HeartSaVioR commented on pull request #31937:
URL: https://github.com/apache/spark/pull/31937#issuecomment-808997100
Let me go through filing PRs as there doesn't look to be further voice on
the overall direction.
--
This is an automated message from the Apache Git Service.
To respond
HeartSaVioR commented on pull request #31937:
URL: https://github.com/apache/spark/pull/31937#issuecomment-806397850
@xuanyuanking @viirya
Sounds great! Thanks for lending your hands.
My current plan on breakdown of PR follows:
* UpdatingSessionIterator +
HeartSaVioR commented on pull request #31937:
URL: https://github.com/apache/spark/pull/31937#issuecomment-806212810
Please let me know if the code diff is too huge to review in a single PR. I
can leave this PR as reference and break down to several PRs. Probably need to
add more code to
HeartSaVioR commented on pull request #31937:
URL: https://github.com/apache/spark/pull/31937#issuecomment-805534587
cc. @tdas @zsxwing @viirya @xuanyuanking @gaborgsomogyi @Ngone51
Appreciate your efforts on reviewing. Thanks!
--
This is an automated message from the Apache Git
HeartSaVioR commented on pull request #31937:
URL: https://github.com/apache/spark/pull/31937#issuecomment-805306871
retest this, please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
HeartSaVioR commented on pull request #31937:
URL: https://github.com/apache/spark/pull/31937#issuecomment-804541654
> Is the second one the approach we took in #31570?
It's not copied from #31570 but the approach is similar. Actually, my old PR
was having both approaches to address
