[GitHub] [spark] HeartSaVioR commented on pull request #33085: [SPARK-35894][BUILD] Introduce new style enforce to not import scala.collection.Seq/IndexedSeq

2021-06-25 Thread GitBox
HeartSaVioR commented on pull request #33085: URL: https://github.com/apache/spark/pull/33085#issuecomment-868896779 Thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [spark] HeartSaVioR commented on pull request #33085: [SPARK-35894][BUILD] Introduce new style enforce to not import scala.collection.Seq/IndexedSeq

2021-06-25 Thread GitBox
HeartSaVioR commented on pull request #33085: URL: https://github.com/apache/spark/pull/33085#issuecomment-868883808 GA build passed for Scala 2.13 build, and style check with new rule is now passed. @srowen Would it be good to go? -- This is an automated message from the Apache G

[GitHub] [spark] HeartSaVioR commented on pull request #33085: [SPARK-35894][BUILD] Introduce new style enforce to not import scala.collection.Seq/IndexedSeq

2021-06-25 Thread GitBox
HeartSaVioR commented on pull request #33085: URL: https://github.com/apache/spark/pull/33085#issuecomment-868533548 Rebased to contain #33084 , and fixed one missed spot in this PR. style check should pass now. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [spark] HeartSaVioR commented on pull request #33085: [SPARK-35894][BUILD] Introduce new style enforce to not import scala.collection.Seq/IndexedSeq

2021-06-25 Thread GitBox
HeartSaVioR commented on pull request #33085: URL: https://github.com/apache/spark/pull/33085#issuecomment-868489092 No, just two lines for now as the style check caught above in PR description. #33084 will handle the fix. -- This is an automated message from the Apache Git Service. To r

[GitHub] [spark] HeartSaVioR commented on pull request #33085: [SPARK-35894][BUILD] Introduce new style enforce to not import scala.collection.Seq/IndexedSeq

2021-06-25 Thread GitBox
HeartSaVioR commented on pull request #33085: URL: https://github.com/apache/spark/pull/33085#issuecomment-868475050 cc. @srowen as I see he had been taking care of Scala things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HeartSaVioR commented on pull request #33085: [SPARK-35894][BUILD] Introduce new style enforce to not import scala.collection.Seq/IndexedSeq

2021-06-25 Thread GitBox
HeartSaVioR commented on pull request #33085: URL: https://github.com/apache/spark/pull/33085#issuecomment-868464382 Build is failing by intention. https://github.com/HeartSaVioR/spark/runs/2913871777?check_suite_focus=true It reports scalastyle failure on master branch: