[GitHub] [spark] HeartSaVioR commented on pull request #33708: [SPARK-36480][SS] SessionWindowStateStoreSaveExec should not filter input rows against watermark

2021-08-11 Thread GitBox
HeartSaVioR commented on pull request #33708: URL: https://github.com/apache/spark/pull/33708#issuecomment-897314969 Thanks @viirya for the quick reviewing and merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] HeartSaVioR commented on pull request #33708: [SPARK-36480][SS] SessionWindowStateStoreSaveExec should not filter input rows against watermark

2021-08-11 Thread GitBox
HeartSaVioR commented on pull request #33708: URL: https://github.com/apache/spark/pull/33708#issuecomment-896809047 cc. @viirya @xuanyuanking I've found the bug while reviewing #33691. I struggled with finding actual reproducer to break but no luck so far. Please let me know if you are