[GitHub] [spark] HeartSaVioR commented on pull request #34502: [SPARK-37224][SS] Optimize write path on RocksDB state store provider

2021-11-17 Thread GitBox
HeartSaVioR commented on pull request #34502: URL: https://github.com/apache/spark/pull/34502#issuecomment-972580577 Thanks for the review @zsxwing ! Merging to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] HeartSaVioR commented on pull request #34502: [SPARK-37224][SS] Optimize write path on RocksDB state store provider

2021-11-17 Thread GitBox
HeartSaVioR commented on pull request #34502: URL: https://github.com/apache/spark/pull/34502#issuecomment-972532165 IDEA made fun of myself; it didn't give the notice on compilation error. Just fixed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] HeartSaVioR commented on pull request #34502: [SPARK-37224][SS] Optimize write path on RocksDB state store provider

2021-11-17 Thread GitBox
HeartSaVioR commented on pull request #34502: URL: https://github.com/apache/spark/pull/34502#issuecomment-972492987 Thanks! I addressed review comments. Please have a look at new change. Thanks in advance! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] HeartSaVioR commented on pull request #34502: [SPARK-37224][SS] Optimize write path on RocksDB state store provider

2021-11-17 Thread GitBox
HeartSaVioR commented on pull request #34502: URL: https://github.com/apache/spark/pull/34502#issuecomment-971438126 Friendly reminder, @tdas @zsxwing @viirya @xuanyuanking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] HeartSaVioR commented on pull request #34502: [SPARK-37224][SS] Optimize write path on RocksDB state store provider

2021-11-17 Thread GitBox
HeartSaVioR commented on pull request #34502: URL: https://github.com/apache/spark/pull/34502#issuecomment-971417163 Please note that 553 Lines are regarding benchmark code and the result. I'll just separate the benchmark and the result to the next PR on top of this, to reduce down the

[GitHub] [spark] HeartSaVioR commented on pull request #34502: [SPARK-37224][SS] Optimize write path on RocksDB state store provider

2021-11-06 Thread GitBox
HeartSaVioR commented on pull request #34502: URL: https://github.com/apache/spark/pull/34502#issuecomment-962530170 @zsxwing @viirya @xuanyuanking Please take a look. Thanks in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on